8000 Review feedback from retronym · scala/scala@df61ab6 · GitHub
[go: up one dir, main page]

Skip to content

Commit df61ab6

Browse files
committed
Review feedback from retronym
1 parent cc70cfb commit df61ab6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,10 +338,11 @@ trait MethodSynthesis {
338338
case _ => NoSymbol
339339
}
340340

341-
// TODO: when is `derivedSym.isOverloaded`??? is it always an error?
342-
private def setterRhs =
341+
private def setterRhs = {
342+
assert(!derivedSym.isOverloaded, s"Unexpected overloaded setter $derivedSym for $basisSym in $enclClass")
343343
if (Field.noFieldFor(tree) || derivedSym.isOverloaded) EmptyTree
344344
else Assign(fieldSelection, Ident(setterParam))
345+
}
345346

346347
private def setterDef = DefDef(derivedSym, setterRhs)
347348
override def derivedTree: Tree = if (setterParam == NoSymbol) EmptyTree else setterDef

0 commit comments

Comments
 (0)
0