8000 Review feedback from retronym · scala/scala@4139bd0 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4139bd0

Browse files
committed
Review feedback from retronym
1 parent d12a510 commit 4139bd0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,10 +349,11 @@ trait MethodSynthesis {
349349
case _ => NoSymbol
350350
}
351351

352-
// TODO: when is `derivedSym.isOverloaded`??? is it always an error?
353-
private def setterRhs =
352+
private def setterRhs = {
353+
assert(!derivedSym.isOverloaded, s"Unexpected overloaded setter $derivedSym for $basisSym in $enclClass")
354354
if (doNotDeriveField || derivedSym.isOverloaded) EmptyTree
355355
else Assign(fieldSelection, Ident(setterParam))
356+
}
356357

357358
private def setterDef = DefDef(derivedSym, setterRhs)
358359
override def derivedTree: Tree = if (setterParam == NoSymbol) EmptyTree else setterDef

0 commit comments

Comments
 (0)
0