8000 Remove redundant overrides of Type.mapOver · scala/scala@0290c18 · GitHub
[go: up one dir, main page]

Skip to content

Commit 0290c18

Browse files
committed
Remove redundant overrides of Type.mapOver
1 parent 0c04d64 commit 0290c18

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/reflect/scala/reflect/internal/Types.scala

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1131,7 +1131,6 @@ trait Types
11311131
override def safeToString: String = "<error>"
11321132
override def narrow: Type = this
11331133
override def kind = "ErrorType"
1134-
override def mapOver(map: TypeMap): Type = this
11351134
}
11361135

11371136
/** An object representing an unknown type, used during type inference.
@@ -1141,7 +1140,6 @@ trait Types
11411140
override def isWildcard = true
11421141
override def safeToString: String = "?"
11431142
override def kind = "WildcardType"
1144-
override def mapOver(map: TypeMap): Type = this
11451143
}
11461144
/** BoundedWildcardTypes, used only during type inference, are created in
11471145
* two places that I can find:
@@ -1171,7 +1169,6 @@ trait Types
11711169
override def isTrivial: Boolean = true
11721170
override def safeToString: String = "<notype>"
11731171
override def kind = "NoType"
1174-
override def mapOver(map: TypeMap): Type = this
11751172
}
11761173

11771174
/** An object representing a non-existing prefix */
@@ -1180,7 +1177,6 @@ trait Types
11801177
override def prefixString = ""
11811178
override def safeToString: String = "<noprefix>"
11821179
override def kind = "NoPrefixType"
1183-
override def mapOver(map: TypeMap): Type = this
11841180
}
11851181

11861182
/** A class for this-types of the form <sym>.this.type
@@ -1207,7 +1203,6 @@ trait Types
12071203
else super.safeToString
12081204
override def narrow: Type = this
12091205
override def kind = "ThisType"
1210-
override def mapOver(map: TypeMap): Type = this
12111206
}
12121207

12131208
final class UniqueThisType(sym: Symbol) extends ThisType(sym) { }
@@ -1869,7 +1864,6 @@ trait Types
18691864
override protected def shouldForceScope = settings.debug || decls.size > 1
18701865
override protected def scopeString = initDecls.mkString(" {\n ", "\n ", "\n}")
18711866
override def safeToString = if (shouldForceScope) formattedToString else super.safeToString
1872-
override def mapOver(map: TypeMap): Type = this
18731867
}
18741868

18751869
object ClassInfoType extends ClassInfoTypeExtractor
@@ -1887,7 +1881,6 @@ trait Types
18871881
override def safeToString: String =
18881882
underlying.toString + "(" + value.escapedStringValue + ")"
18891883
override def kind = "ConstantType"
1890-
override def mapOver(map: TypeMap): Type = this
18911884
}
18921885

18931886
final class UniqueConstantType(value: Constant) extends ConstantType(value)
@@ -2924,7 +2917,6 @@ trait Types
29242917

29252918
case class ImportType(expr: Tree) extends Type {
29262919
override def safeToString = "ImportType("+expr+")"
2927-
override def mapOver(map: TypeMap): Type = this
29282920
}
29292921

29302922
/** A class remembering a type instantiation for some a set of overloaded
@@ -3558,15 +3550,17 @@ trait Types
35583550
*/
35593551
case class NamedType(name: Name, tp: Type) extends Type {
35603552
override def safeToString: String = name.toString +": "+ tp
3561-
override def mapOver(map: TypeMap): Type = this
3553+
// TODO is this needed? We only seem to get here in ContainsCollector in error message generation
3554+
// override def mapOver(map: TypeMap): Type = map.apply(tp)
35623555
}
35633556
/** As with NamedType, used only when calling isApplicable.
35643557
* Records that the application has a wildcard star (aka _*)
35653558
* at the end of it.
35663559
*/
35673560
case class RepeatedType(tp: Type) extends Type {
35683561
override def safeToString: String = tp + ": _*"
3569-
override def mapOver(map: TypeMap): Type = this
3562+
// TODO is this needed? We only seem to get here in ContainsCollector in error message generation
3563+
// override def mapOver(map: TypeMap): Type = map.apply(tp)
35703564
}
35713565

35723566
/** A temporary type representing the erasure of a user-defined value type.
@@ -3583,7 +3577,6 @@ trait Types
35833577
*/
35843578
abstract case class ErasedValueType(valueClazz: Symbol, erasedUnderlying: Type) extends UniqueType {
35853579
override def safeToString = s"ErasedValueType($valueClazz, $erasedUnderlying)"
3586-
override def mapOver(map: TypeMap): Type = this
35873580
}
35883581

35893582
final class UniqueErasedValueType(valueClazz: Symbol, erasedUnderlying: Type) extends ErasedValueType(valueClazz, erasedUnderlying)
@@ -3602,7 +3595,6 @@ trait Types
36023595
override def complete(sym: Symbol)
36033596
override def safeToString = "<?>"
36043597
override def kind = "LazyType"
3605-
override def mapOver(map: TypeMap): Type = this
36063598
}
36073599

36083600
/** A marker trait representing an as-yet unevaluated type

0 commit comments

Comments
 (0)
0