8000 SIP-27: Trailing Commas, revised document by dwijnand · Pull Request #625 · scala/docs.scala-lang · GitHub
[go: up one dir, main page]
Skip to content

SIP-27: Trailing Commas, revised document #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 25, 2016
Merged

SIP-27: Trailing Commas, revised document #625

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16bfa8d
SIP-27: Simplify the History
dwijnand Nov 12, 2016
d51d757
SIP-27: Move back to pending/under review
dwijnand Nov 12, 2016
049df35
SIP-27: Major rework: multi-line, 2 variants & spec
dwijnand Nov 12, 2016
3d9f0ea
SIP-27: Re-word my recommendation for the first variant
dwijnand Nov 12, 2016
0066ac4
SIP-27: Be more explicit about multi-line
dwijnand Nov 15, 2016
206fba0
SIP-27: Re-word that the impl PR == the current proposal
dwijnand Nov 21, 2016
15e15e3
SIP-27: Add links to PR numbers
dwijnand Nov 21, 2016
3f11780
SIP-27: Consistent section titles
dwijnand Nov 24, 2016
d1ebb53
SIP-27: Briefly explain why no single-line trailing commas
dwijnand Nov 24, 2016
fbf4172
SIP-27: Try & clarify the drawbacks of whole grammar trailing comma s…
dwijnand Nov 24, 2016
afd7091
SIP-27: Clarify the description of the proposed implementation
dwijnand Nov 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SIP-27: Re-word that the impl PR == the current proposal
  • Loading branch information
@dwijnand
dwijnand committed Nov 21, 2016
commit 206fba0202c3de6957df9ef034629b62b56e507f
2 changes: 1 addition & 1 deletion sips/completed/_posts/2016-06-25-trailing-commas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ class Bippy(

## Implementation

The implementation of trailing commas is a matter of changing some of the implementation of Scala's parser. An implementation of an earlier version of this proposal can be found at [scala/scala#5245][].
The implementation of trailing commas is a matter of changing some of the implementation of Scala's parser. An implementation of this proposal can be found at [scala/scala#5245][].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "is limited to changing Parsers.scala in the Scala compiler.`?


## Drawbacks/Trade-offs

Expand Down
0