bug symfony#60168 [Console] Correctly convert SIGSYS to its name (cs278)

nicolas-grekas · nicolas-grekas · commit aa40689deff8 · 2025-04-07T20:46:34.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Console] Correctly convert `SIGSYS` to its name | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | N/A | License | MIT Because of a [PHP easter egg](https://stackoverflow.com/a/48485134) using the `SignalMap::getSignalName()` method with `SIGSYS` results in `'SIGBABY'` instead of the expected `'SIGSYS'` being returned. https://github.com/php/php-src/blob/213949dc340e17b7234c8a753703b1ab455c8585/ext/pcntl/pcntl_arginfo.h#L398-L400 ```php require 'vendor/autoload.php'; var_dump(Symfony\Component\Console\SignalRegistry\SignalMap::getSignalName(SIGSYS)); // string(7) "SIGBABY" ``` Commits ------- 9463951 Correctly convert SIGSYS to its name
diff --git a/src/Symfony/Component/Console/SignalRegistry/SignalMap.php b/src/Symfony/Component/Console/SignalRegistry/SignalMap.php
@@ -27,7 +27,7 @@ public static function getSignalName(int $signal): ?string
         if (!isset(self::$map)) {
             $r = new \ReflectionExtension('pcntl');
             $c = $r->getConstants();
-            $map = array_filter($c, fn ($k) => str_starts_with($k, 'SIG') && !str_starts_with($k, 'SIG_'), \ARRAY_FILTER_USE_KEY);
+            $map = array_filter($c, fn ($k) => str_starts_with($k, 'SIG') && !str_starts_with($k, 'SIG_') && 'SIGBABY' !== $k, \ARRAY_FILTER_USE_KEY);
             self::$map = array_flip($map);
         }
 
diff --git a/src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php b/src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php
@@ -22,6 +22,7 @@ class SignalMapTest extends TestCase
      * @testWith [2, "SIGINT"]
      *           [9, "SIGKILL"]
      *           [15, "SIGTERM"]
+     *           [31, "SIGSYS"]
      */
     public function testSignalExists(int $signal, string $expected)
     {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public static function getSignalName(int $signal): ?string`
`27`	`27`	`if (!isset(self::$map)) {`
`28`	`28`	`$r = new \ReflectionExtension('pcntl');`
`29`	`29`	`$c = $r->getConstants();`
`30`		`- $map = array_filter($c, fn ($k) => str_starts_with($k, 'SIG') && !str_starts_with($k, 'SIG_'), \ARRAY_FILTER_USE_KEY);`
	`30`	`+ $map = array_filter($c, fn ($k) => str_starts_with($k, 'SIG') && !str_starts_with($k, 'SIG_') && 'SIGBABY' !== $k, \ARRAY_FILTER_USE_KEY);`
`31`	`31`	`self::$map = array_flip($map);`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ class SignalMapTest extends TestCase`
`22`	`22`	`* @testWith [2, "SIGINT"]`
`23`	`23`	`* [9, "SIGKILL"]`
`24`	`24`	`* [15, "SIGTERM"]`
	`25`	`+ * [31, "SIGSYS"]`
`25`	`26`	`*/`
`26`	`27`	`public function testSignalExists(int $signal, string $expected)`
`27`	`28`	`{`