8000 [HttpKernel] excluded a test on PHP 5.3.16, which is buggy (PHP, not … · samswitz/symfony@9a355e9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 9a355e9

Browse files
committed
[HttpKernel] excluded a test on PHP 5.3.16, which is buggy (PHP, not Symfony ;))
1 parent 04c46eb commit 9a355e9

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

tests/Symfony/Tests/Component/HttpKernel/Controller/ControllerResolverTest.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,15 @@ public function testGetArguments()
119119
$request->attributes->set('foobar', 'foobar');
120120
$controller = array(new self(), 'controllerMethod3');
121121

122-
try {
123-
$resolver->getArguments($request, $controller);
124-
$this->fail('->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
125-
} catch (\Exception $e) {
126-
$this->assertInstanceOf('\RuntimeException', $e, '->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
122+
if (version_compare(PHP_VERSION, '5.3.16', '==')) {
123+
$this->markTestSkipped('PHP 5.3.16 has a major bug in the Reflection sub-system');
124+
} else {
125+
try {
126+
$resolver->getArguments($request, $controller);
127+
$this->fail('->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
128+
} catch (\Exception $e) {
129+
$this->assertInstanceOf('\RuntimeException', $e, '->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
130+
}
127131
}
128132

129133
$request = Request::create('/');

0 commit comments

Comments
 (0)
0