Fix an issue where a empty script would still get arguments.

iclanton · iclanton · commit 97043a22b57d · 2021-01-07T21:49:28.000-08:00
diff --git a/apps/rush-lib/src/logic/TaskSelector.ts b/apps/rush-lib/src/logic/TaskSelector.ts
@@ -51,8 +51,12 @@ export class TaskSelector {
       return undefined;
     }
 
-    const taskCommand: string = `${script} ${customParameterValues.join(' ')}`;
-    return process.platform === 'win32' ? convertSlashesForWindows(taskCommand) : taskCommand;
+    if (!script) {
+      return '';
+    } else {
+      const taskCommand: string = `${script} ${customParameterValues.join(' ')}`;
+      return process.platform === 'win32' ? convertSlashesForWindows(taskCommand) : taskCommand;
+    }
   }
 
   public registerTasks(): TaskCollection {

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,12 @@ export class TaskSelector {`
`51`	`51`	`return undefined;`
`52`	`52`	`}`
`53`	`53`
`54`		- const taskCommand: string = `${script} ${customParameterValues.join(' ')}`;
`55`		`- return process.platform === 'win32' ? convertSlashesForWindows(taskCommand) : taskCommand;`
	`54`	`+ if (!script) {`
	`55`	`+ return '';`
	`56`	`+ } else {`
	`57`	+ const taskCommand: string = `${script} ${customParameterValues.join(' ')}`;
	`58`	`+ return process.platform === 'win32' ? convertSlashesForWindows(taskCommand) : taskCommand;`
	`59`	`+ }`
`56`	`60`	`}`
`57`	`61`
`58`	`62`	`public registerTasks(): TaskCollection {`