10000 Merge branch 'cleanup_prereqs' into 'master' · saltstack/salt-user-guide@46ec8b1 · GitHub
[go: up one dir, main page]

Skip to content

Commit 46ec8b1

Browse files
author
Alyssa Rock
committed
Merge branch 'cleanup_prereqs' into 'master'
Cleanup prereqs See merge request saltstack/open/docs/salt-user-guide!84
2 parents 7ede468 + 24231b8 commit 46ec8b1

File tree

1 file changed

+45
-2
lines changed

1 file changed

+45
-2
lines changed

CONTRIBUTING.rst

Lines changed: 45 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,39 @@ If you do not already have one, create a free account on the `GitLab sign-up pag
7575
For local development, the following prerequisites are needed:
7676

7777
* `git <https://git-scm.com/book/en/v2/Getting-Started-Installing-Git>`__
78-
* `Python 3.6+ <https://realpython.com/installing-python/>`__
78+
* `Python 3.7+ <https://realpython.com/installing-python/>`__
7979
* `Ability to create python venv <https://realpython.com/python-virtual-environments-a-primer/>`__
8080
* `vale <https://docs.errata.ai/vale/install>`__
8181
* `vendir <https://carvel.dev/#install>`__
8282

8383

84+
Linux/macOS users
85+
-----------------
86+
We recommend installing `Homebrew <https://brew.sh/>`__, as it allows easy installation of
87+
`vale <https://docs.errata.ai/vale/install>`__ and `vendir <https://carvel.dev/#install>`__.
88+
89+
To install Homebrew:
90+
91+
.. code-block:: bash
92+
93+
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
94+
95+
96+
You can then proceed with installing prerequisites:
97+
98+
.. code-block:: bash
99+
100+
# Update Homebrew
101+
brew update
102+
103+
# vale
104+
brew install vale
105+
106+
# vendir
107+
brew tap vmware-tanzu/carvel
108+
brew install vendir
109+
110+
84111
Windows users
85112
-------------
86113
For the best experience, when 10000 contributing from a Windows OS to projects using
@@ -125,6 +152,18 @@ From the ``git`` package page on Chocolatey:
125152
* Git GUI
126153
* Shell Integration
127154

155+
If you're using WSL, proceed with installing requirements from `Linux/macOS users`_ above.
156+
157+
Otherwise, you can then proceed with installing prerequisites:
158+
159+
.. code-block:: bash
160+
161+
# vale
162+
choco install vale
163+
164+
# vendir
165+
choco install vendir
166+
128167
129168
Fork, clone, and branch the repo
130169
================================
@@ -196,7 +235,7 @@ From within your local copy of the forked repo:
196235
197236
# Setup venv
198237
python3 -m venv .venv
199-
# If Python 3.6+ is in path as 'python', use the following instead:
238+
# If Python 3.7+ is in path as 'python', use the following instead:
200239
# python -m venv .venv
201240
202241
# Activate venv
@@ -212,6 +251,10 @@ From within your local copy of the forked repo:
212251
# Setup pre-commit
213252
pre-commit install
214253
254+
# If you want to use Vale's in-editor style checking immediately
255+
# (Will be pulled down automatically at first commit)
256+
pre-commit run vendir
257+
215258
216259
All required files should now be in place.
217260

0 commit comments

Comments
 (0)
0