fix(bump): add bump support with custom type + scope + exclamation mark

jmattheis · Lee-W · commit 8f19b24e3e1c · 2023-10-14T09:50:07.000+08:00
The regex didn't match the following commit with exclamation mark, and
therefore didn't update the version.

    chore(deps)!: drop support for Python 3.9

The regex was simplified, because a lot groups were not needed.
diff --git a/commitizen/defaults.py b/commitizen/defaults.py
@@ -104,7 +104,7 @@ class Settings(TypedDict, total=False):
 MINOR = "MINOR"
 PATCH = "PATCH"
 
-bump_pattern = r"^(((BREAKING[\-\ ]CHANGE|feat|fix|refactor|perf)(\(.+\))?(!)?)|\w+!):"
+bump_pattern = r"^((BREAKING[\-\ ]CHANGE|\w+)(\(.+\))?!?):"
 bump_map = OrderedDict(
     (
         (r"^.+!$", MAJOR),
diff --git a/tests/test_bump_find_increment.py b/tests/test_bump_find_increment.py
@@ -58,6 +58,12 @@
     "fix(setup.py): future is now required for every python version",
 ]
 
+MAJOR_INCREMENTS_EXCLAMATION_OTHER_TYPE_WITH_SCOPE_CC = [
+    "chore(deps)!: drop support for Python 3.9",
+    "docs(README): motivation",
+    "fix(setup.py): future is now required for every python version",
+]
+
 PATCH_INCREMENTS_SVE = ["readme motivation PATCH", "fix setup.py PATCH"]
 
 MINOR_INCREMENTS_SVE = [
@@ -85,6 +91,7 @@
         (MAJOR_INCREMENTS_BREAKING_CHANGE_CC, "MAJOR"),
         (MAJOR_INCREMENTS_BREAKING_CHANGE_ALT_CC, "MAJOR"),
         (MAJOR_INCREMENTS_EXCLAMATION_OTHER_TYPE_CC, "MAJOR"),
+        (MAJOR_INCREMENTS_EXCLAMATION_OTHER_TYPE_WITH_SCOPE_CC, "MAJOR"),
         (MAJOR_INCREMENTS_EXCLAMATION_CC, "MAJOR"),
         (MAJOR_INCREMENTS_EXCLAMATION_CC_SAMPLE_2, "MAJOR"),
         (NONE_INCREMENT_CC, None),

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ class Settings(TypedDict, total=False):`
`104`	`104`	`MINOR = "MINOR"`
`105`	`105`	`PATCH = "PATCH"`
`106`	`106`
`107`		`-bump_pattern = r"^(((BREAKING[\-\ ]CHANGE\|feat\|fix\|refactor\|perf)(\(.+\))?(!)?)\|\w+!):"`
	`107`	`+bump_pattern = r"^((BREAKING[\-\ ]CHANGE\|\w+)(\(.+\))?!?):"`
`108`	`108`	`bump_map = OrderedDict(`
`109`	`109`	`(`
`110`	`110`	`(r"^.+!$", MAJOR),`