Fix see other response

lindyhopchris · lindyhopchris · commit 331c66c58855 · 2018-11-22T10:57:15.000Z
diff --git a/src/Http/Responses/Responses.php b/src/Http/Responses/Responses.php
@@ -288,7 +288,8 @@ public function accepted(AsynchronousProcess $job, array $links = [], $meta = nu
     public function process(AsynchronousProcess $job, array $links = [], $meta = null, array $headers = [])
     {
         if (!$job->isPending() && $location = $job->getLocation()) {
-            return response()->redirectTo($location, Response::HTTP_SEE_OTHER, $headers);
+            $headers['Location'] = $location;
+            return $this->createJsonApiResponse(null, Response::HTTP_SEE_OTHER, $headers);
         }
 
         return $this->getContentResponse($job, self::HTTP_OK, $links, $meta, $headers);
diff --git a/tests/lib/Integration/Queue/QueueJobsTest.php b/tests/lib/Integration/Queue/QueueJobsTest.php
@@ -34,16 +34,20 @@ public function testReadPending()
 
     /**
      * When job process is done, the request SHOULD return a status 303 See other
-     * with a link in Location header.
+     * with a link in Location header. The spec recommendation shows a response with
+     * a Content-Type header as `application/vnd.api+json` but no content in the response body.
      */
     public function testReadNotPending()
     {
        $job = factory(ClientJob::class)->states('success')->create();
-       $location = "http://localhost/api/v1/downloads/{$job->resource_id}";
 
-       $this->getJsonApi($this->jobUrl($job))
+       $response = $this
+           ->getJsonApi($this->jobUrl($job))
            ->assertStatus(303)
-           ->assertHeader('Location', $location);
+           ->assertLocation('/api/v1/downloads/' . $job->resource_id)
+           ->assertHeader('Content-Type', 'application/vnd.api+json');
+
+       $this->assertEmpty($response->getContent(), 'content is empty.');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,8 @@ public function accepted(AsynchronousProcess $job, array $links = [], $meta = nu`
`288`	`288`	`public function process(AsynchronousProcess $job, array $links = [], $meta = null, array $headers = [])`
`289`	`289`	`{`
`290`	`290`	`if (!$job->isPending() && $location = $job->getLocation()) {`
`291`		`- return response()->redirectTo($location, Response::HTTP_SEE_OTHER, $headers);`
	`291`	`+ $headers['Location'] = $location;`
	`292`	`+ return $this->createJsonApiResponse(null, Response::HTTP_SEE_OTHER, $headers);`
`292`	`293`	`}`
`293`	`294`
`294`	`295`	`return $this->getContentResponse($job, self::HTTP_OK, $links, $meta, $headers);`