Close neomerx#186

neomerx · neomerx · commit f6a07b8ce329 · 2017-09-27T19:52:10.000+03:00
diff --git a/src/Http/Query/QueryParametersParser.php b/src/Http/Query/QueryParametersParser.php
@@ -82,11 +82,10 @@ private function getIncludePaths(array $parameters)
      * @return array|null
      *
      * @SuppressWarnings(PHPMD.StaticAccess)
-     * @SuppressWarnings(PHPMD.ElseExpression)
      */
     private function getFieldSets(array $parameters)
     {
-        $result    = [];
+        $result = null;
         $fieldSets = $this->getParamOrNull($parameters, self::PARAM_FIELDS);
         if (empty($fieldSets) === false && is_array($fieldSets)) {
             foreach ($fieldSets as $type => $fields) {
@@ -97,8 +96,6 @@ private function getFieldSets(array $parameters)
                 }
                 $result[$type] = (empty($fields) === true ? [] : explode(',', $fields));
             }
-        } else {
-            $result = null;
         }
 
         return $result;

Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,10 @@ private function getIncludePaths(array $parameters)`
`82`	`82`	`* @return array\|null`
`83`	`83`	`*`
`84`	`84`	`* @SuppressWarnings(PHPMD.StaticAccess)`
`85`		`- * @SuppressWarnings(PHPMD.ElseExpression)`
`86`	`85`	`*/`
`87`	`86`	`private function getFieldSets(array $parameters)`
`88`	`87`	`{`
`89`		`- $result = [];`
	`88`	`+ $result = null;`
`90`	`89`	`$fieldSets = $this->getParamOrNull($parameters, self::PARAM_FIELDS);`
`91`	`90`	`if (empty($fieldSets) === false && is_array($fieldSets)) {`
`92`	`91`	`foreach ($fieldSets as $type => $fields) {`
`@@ -97,8 +96,6 @@ private function getFieldSets(array $parameters)`
`97`	`96`	`}`
`98`	`97`	`$result[$type] = (empty($fields) === true ? [] : explode(',', $fields));`
`99`	`98`	`}`
`100`		`- } else {`
`101`		`- $result = null;`
`102`	`99`	`}`
`103`	`100`
`104`	`101`	`return $result;`