8000 Not explicit function name · Issue #175 · ryanmcdermott/clean-code-javascript · GitHub
[go: up one dir, main page]

Skip to content
Not explicit function name #175
@AnnaNee

Description

@AnnaNee

In section Function names should say what they do you're explicitly saying that you're adding a month to a date, addMonthToDate().

In section Remove duplicate code you're showing the employees list using showList().

Shouldn't that be showEmployeesList() as well, in order to explicitly tell what will be shown, so you just have to pass the type of the employee as an argument (managers or developers in that context)?

I'm not really sure about it, which is why I wanted to discuss about. Thanks for this great work!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0