10000
We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in hold streams are not logged
Check stackblitz example
this.hold( of(null).pipe(switchMap(() => throwError("error"))), value => { console.log(value); } );
Result in console: Expected result in console: error
error
Add console.error in hold definition
hold<S>( obsOrObsWithSideEffect: Observable<S>, sideEffectFn?: (arg: S) => void ): void { const sideEffect = obsOrObsWithSideEffect.pipe(catchError(e => { console.error(e) return EMPTY })) if (typeof sideEffectFn === 'function') { this.effectObservable.nextEffectObservable( sideEffect.pipe(tap(sideEffectFn)) ); return; } this.effectObservable.nextEffectObservable(sideEffect); }
The text was updated successfully, but these errors were encountered:
Thx for the issue! Get back with updates.
Sorry, something went wrong.
Hi!
In the PR for RxEffects we implemented angulars error handler. Would be col if we could do the same here. https://github.com/rx-angular/rx-angular/pull/569/files#diff-9afb99d5c66b09318924448921fd9e1f7eefe3b2d5244af8f125266f57378c93R75
Successfully merging a pull request may close this issue.
Uh oh!
There was an error while loading. Please reload this page.
Description
Errors in hold streams are not logged
Steps to Reproduce the Issue
Check stackblitz example
Result in console:
Expected result in console:
error
Solution
Add console.error in hold definition
The text was updated successfully, but these errors were encountered: