bug symfony#31071 property normalizer should also pass format and context to isAllowedAttribute (dbu)

nicolas-grekas · nicolas-grekas · commit 2a1137a05c90 · 2019-04-11T13:03:39.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- property normalizer should also pass format and context to isAllowedAttribute | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | found while working on symfony#30888 | License | MIT | Doc PR | - the context and format are optional parameters to `isAllowedAttribute`, but should be forwarded. due to this omission, the PropertyNormalizer was ignoring the 'attributes' context option (and does in version 4 also ignore the 'ignore_attributes' context option - that one is a property on the normalizer class in version 3 and therefore not ignored here) Commits ------- 13e2fb7 property normalizer should also pass format and context to isAllowedAttribute
diff --git a/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php
@@ -102,7 +102,7 @@ protected function extractAttributes($object, $format = null, array $context = [
 
         do {
             foreach ($reflectionObject->getProperties() as $property) {
-                if (!$this->isAllowedAttribute($reflectionObject->getName(), $property->name)) {
+                if (!$this->isAllowedAttribute($reflectionObject->getName(), $property->name, $format, $context)) {
                     continue;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ protected function extractAttributes($object, $format = null, array $context = [`
`102`	`102`
`103`	`103`	`do {`
`104`	`104`	`foreach ($reflectionObject->getProperties() as $property) {`
`105`		`- if (!$this->isAllowedAttribute($reflectionObject->getName(), $property->name)) {`
	`105`	`+ if (!$this->isAllowedAttribute($reflectionObject->getName(), $property->name, $format, $context)) {`
`106`	`106`	`continue;`
`107`	`107`	`}`
`108`	`108`