8000 updating classes to use standard attrs · rusty0209/botbuilder-python@2b3f2bf · GitHub
[go: up one dir, main page]
Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2b3f2bf

Browse files
Virtual-JoshVirtual-Josh
committed
updating classes to use standard attrs
1 parent 96f262d commit 2b3f2bf

File tree

5 files changed

+13
-100
lines changed

5 files changed

+13
-100
lines changed

‎libraries/botbuilder-core/botbuilder/core/Teams/teams_activity_handler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ async def on_conversation_update_activity(self, turn_context: TurnContext):
6464
turn_context,
6565
)
6666

67+
print(turn_context.activity)
6768
if channel_data is not None:
6869
if channel_data.event_type == "channelCreated":
6970
return await self.on_teams_channel_created_activity(

‎libraries/botbuilder-schema/botbuilder/schema/teams/channel_info.py

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,8 @@
77
# regenerated.
88

99

10-
class ChannelInfo:
10+
class ChannelInfo(object):
1111
def __init__(self, id="", name=""):
12-
self._id = id
13-
self._name = name
14-
15-
@property
16-
def id(self):
17-
return self._id
18-
19-
@id.setter
20-
def id(self, id):
21-
self._id = id
22-
23-
@property
24-
def name(self):
25-
return self._name
26-
27-
@name.setter
28-
def name(self, name):
29-
self._name = name
12+
self.id = id
13+
self.name = name
14+

‎libraries/botbuilder-schema/botbuilder/schema/teams/notification_info.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,4 @@
99

1010
class NotificationInfo:
1111
def __init__(self, alert: bool = False):
12-
self._alert = alert
13-
14-
@property
15-
def alert():
16-
return self._alert
17-
18-
@alert.setter
19-
def alert(alert):
20-
self._alert = alert
12+
self.alert = alert

‎libraries/botbuilder-schema/botbuilder/schema/teams/team_info.py

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,6 @@
99

1010
class TeamInfo:
1111
def __init__(self, id="", name="", aadGroupId=""):
12-
self._id = id
13-
self._name = name
14-
self._aad_group_id = aadGroupId
15-
16-
def get_id(self):
17-
return self._id
18-
19-
def set_id(self, id):
20-
self._id = id
21-
22-
def get_name(self):
23-
return self._name
24-
25-
def set_name(self, name):
26-
self._name = name
27-
28-
def get_aad_group_id(self):
29-
return self._aad_group_id
30-
31-
def set_aad_group_id(self, aad_group_id):
32-
self._aad_group_id = aad_group_id
33-
34-
id = property(get_id, set_id)
35-
name = property(get_name, set_name)
36-
aad_group_id = property(get_aad_group_id, set_aad_group_id)
12+
self.id = id
13+
self.name = name
14+
self.aad_group_id = aadGroupId

‎libraries/botbuilder-schema/botbuilder/schema/teams/teams_channel_account.py

Lines changed: 4 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -24,50 +24,7 @@ def __init__(
2424
super().__init__(
2525
**{"id": id, "name": name, "aad_object_id": aad_object_id, "role": role}
2626
)
27-
self._given_name = given_name
28-
self._surname = surname
29-
self._email = email
30-
self._user_principal_name = userPrincipalName
31-
32-
def get_id(self):
33-
return self._id
34-
35-
def set_id(self, id):
36-
self._id = id
37-
38-
def get_name(self):
39-
return self._name
40-
41-
def set_name(self, name):
42-
self._name = name
43-
44-
def get_given_name(self):
45-
return self._given_name
46-
47-
def set_given_name(self, given_name):
48-
self._given_name = given_name
49-
50-
def get_surname(self):
51-
return self._surname
52-
53-
def set_surname(self, surname):
54-
self._surname = surname
55-
56-
def get_email(self):
57-
return self._email
58-
59-
def set_email(self, email):
60-
self._email = email
61-
62-
def get_user_principal_name(self):
63-
return self._user_principal_name
64-
65-
def set_user_principal_name(self, user_principal_name):
66-
self._user_principal_name = user_principal_name
67-
68-
id = property(get_id, set_id)
69-
name = property(get_name, set_name)
70-
given_name = property(get_given_name, set_given_name)
71-
surname = property(get_surname, set_surname)
72-
email = property(get_email, set_email)
73-
user_principal_name = property(get_user_principal_name, set_user_principal_name)
27+
self.given_name = given_name
28+
self.surname = surname
29+
self.email = email
30+
self.user_principal_name = userPrincipalName

0 commit comments

Comments
 (0)
0