Fix: wrong masking in ERDP (#132)

ytoml · web-flow · commit 85419377dc8b · 2022-04-20T15:30:20.000+09:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 ### Fixed
 - Outdated code example in `README.md` is fixed.
 - Removed all the use of deprecated code.
+- Wrong masking in `EventRingDequeuePointerRegister::event_ring_dequeue_pointer` is fixed.
 
 ## 0.8.2 - 2021-05-13
 ### Removed
diff --git a/src/registers/runtime.rs b/src/registers/runtime.rs
@@ -197,7 +197,7 @@ impl EventRingDequeuePointerRegister {
     /// Returns the address of the current Event Ring Dequeue Pointer.
     #[must_use]
     pub fn event_ring_dequeue_pointer(self) -> u64 {
-        self.0 & 0b1111
+        self.0 & !0b1111
     }
 
     /// Sets the address of the current Event Ring Dequeue Pointer. It must be 16 byte aligned.

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ impl EventRingDequeuePointerRegister {`
`197`	`197`	`/// Returns the address of the current Event Ring Dequeue Pointer.`
`198`	`198`	`#[must_use]`
`199`	`199`	`pub fn event_ring_dequeue_pointer(self) -> u64 {`
`200`		`- self.0 & 0b1111`
	`200`	`+ self.0 & !0b1111`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`/// Sets the address of the current Event Ring Dequeue Pointer. It must be 16 byte aligned.`