FIX: Use .visit() for array traversal in var

bluss · bluss · commit 225d967e12d5 · 2021-01-10T15:19:43.000+01:00
Using iterators for multidimensional arrays is discouraged, prefer using
higher-order methods (mentioned in the module documentation's main
page).
diff --git a/src/numeric/impl_numeric.rs b/src/numeric/impl_numeric.rs
@@ -15,8 +15,6 @@ use crate::imp_prelude::*;
 use crate::itertools::enumerate;
 use crate::numeric_util;
 
-use crate::{FoldWhile, Zip};
-
 /// # Numerical Methods for Arrays
 impl<A, S, D> ArrayBase<S, D>
 where
@@ -169,12 +167,14 @@ where
         let dof = n - ddof;
         let mut mean = A::zero();
         let mut sum_sq = A::zero();
-        for (i, &x) in self.into_iter().enumerate() {
+        let mut i = 0;
+        self.visit(|&x| {
             let count = A::from_usize(i + 1).expect("Converting index to `A` must not fail.");
             let delta = x - mean;
             mean = mean + delta / count;
             sum_sq = (x - mean).mul_add(delta, sum_sq);
-        }
+            i += 1;
+        });
         sum_sq / dof
     }
 
