8000 Update `replace_consts` lint wrt. stabilized `assoc_int_consts` feature · Issue #5269 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]

Skip to content
Update replace_consts lint wrt. stabilized assoc_int_consts feature #5269
@phansch

Description

@phansch

rust-lang/rust#68952 stabilized the assoc_int_consts feature for Rust 1.34. For Clippy this is relevant for at least the replace_consts lint:

As far as I can tell, that lint was meant to suggest to use the associated methods on the integer primitives, instead of the constants that have now been soft-deprecated in rust-lang/rust#68952. Although, the lint doesn't really provide a reason why one is better over the other. (Please correct me if I misunderstood that lint)

The RFC also mentions a deprecation of the associated functions the lint is currently suggesting, so we might want to deprecate replace_consts and have a different lint that suggests the associated constants instead of the associated methods 🔄

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-questionCategory: QuestionsS-needs-discussionStatus: Needs further discussion before merging or work can be started

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0