-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-async-awaitArea: Async & AwaitArea: Async & AwaitA-codegenArea: Code generationArea: Code generationE-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleI-slowIssue: Problems and improvements with respect to performance of generated code.Issue: Problems and improvements with respect to performance of generated code.ICEBreaker-LLVMBugs identified for the LLVM ICE-breaker groupBugs identified for the LLVM ICE-breaker groupP-lowLow priorityLow priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
See #69033 (comment); @kpp reports a 200%+ regression on some futures microbenchmarks, e.g.:
future::ready/async_combinators
time: [1.5699 ns 1.5743 ns 1.5793 ns]
change: [+279.32% +282.34% +285.20%] (p = 0.00 < 0.05)
Performance has regressed.
The benchmarks are at https://github.com/kpp/futures-async-combinators/.
I bisected this to 57e1da5, which most likely implicates #69837.
Metadata
Metadata
Assignees
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-async-awaitArea: Async & AwaitArea: Async & AwaitA-codegenArea: Code generationArea: Code generationE-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleI-slowIssue: Problems and improvements with respect to performance of generated code.Issue: Problems and improvements with respect to performance of generated code.ICEBreaker-LLVMBugs identified for the LLVM ICE-breaker groupBugs identified for the LLVM ICE-breaker groupP-lowLow priorityLow priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.