-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed as not planned
Labels
A-save-analysisArea: saving results of analyses such as inference and bor
7F4E
rowck results to a file.Area: saving results of analyses such as inference and borrowck results to a file.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
In the save-analysis file of liballoc, the value/signature of
Line 98 in 14b9665
pub unsafe fn local_waker<W: Wake + 'static>(wake: Arc<W>) -> LocalWaker { |
fn <W> (wake: Arc<W>) -> LocalWaker
, which is not valid rust code.
There is little documentation available for the save-analysis, but as far as I understood it, the value
field is supposed to represent the signature. In most other languages, the signature of a function doesn't include the parameter names.
For consistency, I think it would be better if the field would either include the function name or leave of the parameter names.
Edit: I want this to be able to parse the string with syn, which expects either a name for the function or no names for the arguments.
timsueberkrueb
Metadata
Metadata
Assignees
Labels
A-save-analysisArea: saving results of analyses such as inference and borrowck results to a file.Area: saving results of analyses such as inference and borrowck results to a file.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.