This optimization can't be applied to {partial_}cmp{_by}

yotamofek · yotamofek · commit d9f58d45d67b · 2025-02-16T11:50:38.000Z
diff --git a/library/core/src/iter/traits/iterator.rs b/library/core/src/iter/traits/iterator.rs
@@ -3616,7 +3616,7 @@ pub trait Iterator {
             }
         }
 
-        match SpecIterCompare::spec_iter_compare(self, other.into_iter(), compare(cmp)) {
+        match iter_compare(self, other.into_iter(), compare(cmp)) {
             ControlFlow::Continue(ord) => ord,
             ControlFlow::Break(ord) => ord,
         }
@@ -3708,7 +3708,7 @@ pub trait Iterator {
             }
         }
 
-        match SpecIterCompare::spec_iter_compare(self, other.into_iter(), compare(partial_cmp)) {
+        match iter_compare(self, other.into_iter(), compare(partial_cmp)) {
             ControlFlow::Continue(ord) => Some(ord),
             ControlFlow::Break(ord) => ord,
         }

Original file line number	Diff line number	Diff line change
`@@ -3616,7 +3616,7 @@ pub trait Iterator {`
`3616`	`3616`	`}`
`3617`	`3617`	`}`
`3618`	`3618`
`3619`		`- match SpecIterCompare::spec_iter_compare(self, other.into_iter(), compare(cmp)) {`
	`3619`	`+ match iter_compare(self, other.into_iter(), compare(cmp)) {`
`3620`	`3620`	`ControlFlow::Continue(ord) => ord,`
`3621`	`3621`	`ControlFlow::Break(ord) => ord,`
`3622`	`3622`	`}`
`@@ -3708,7 +3708,7 @@ pub trait Iterator {`
`3708`	`3708`	`}`
`3709`	`3709`	`}`
`3710`	`3710`
`3711`		`- match SpecIterCompare::spec_iter_compare(self, other.into_iter(), compare(partial_cmp)) {`
	`3711`	`+ match iter_compare(self, other.into_iter(), compare(partial_cmp)) {`
`3712`	`3712`	`ControlFlow::Continue(ord) => Some(ord),`
`3713`	`3713`	`ControlFlow::Break(ord) => ord,`
`3714`	`3714`	`}`