std: explain unconventional choice of let-else binding over while-let loop

joboet · joboet · commit 88efb1bdefc6 · 2023-10-09T15:09:18.000+02:00
diff --git a/library/std/src/sys/windows/thread_local_key.rs b/library/std/src/sys/windows/thread_local_key.rs
@@ -43,6 +43,9 @@ unsafe fn run_keyless_dtors() {
     // guarantee that a TLS key cannot be set after it is flagged for
     // destruction.
     loop {
+        // Use a let-else binding to ensure the `RefCell` guard is dropped
+        // immediately. Otherwise, a panic would occur if a TLS destructor
+        // tries to access the list.
         let Some((ptr, dtor)) = DESTRUCTORS.borrow_mut().pop() else {
             break;
         };
