Description
Proposal
To avoid the issue of locking between normal builds and rust-analyzer builds, we should set the in-tree rust-analyzer settings (accessible via x setup editor) to make rust-analyzer use a build directory separate from the one used by bootstrap.
In addition to that, it would be good to decide on the following 2 options:
-
Use "build/rust-analyzer/" (currently used by Helix settings)
The benefit is that we don't have to add another top-level directory.
make rust-analyzer use a dedicated build directory rust#141839 follows this approach. -
Use "build-rust-analyzer/"
The benefit is that
x clean --alldoes not also remove rust-analyzer build artefacts
(because "build/" belongs to bootstrap, probably).
Process
The main points of the Major Change Process are as follows:
- File an issue describing the proposal.
- A compiler team member or contributor who is knowledgeable in the area can second by writing
@rustbot second.- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
-C flag, then full team check-off is required. - Compiler team members can initiate a check-off via
@rfcbot fcp mergeon either the MCP or the PR.
- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
- Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.
You can read more about Major Change Proposals on forge.