8000 change tooltip/popover html default to false for xss safety net · rusongyu/bootstrap@003fccc · GitHub
[go: up one dir, main page]

Skip to content

Commit 003fccc

Browse files
committed
change tooltip/popover html default to false for xss safety net
1 parent ebf94c5 commit 003fccc

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

docs/assets/js/bootstrap-tooltip.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
, trigger: 'hover'
270270
, title: ''
271271
, delay: 0
272-
, html: true
272+
, html: false
273273
}
274274

275275
}(window.jQuery);

docs/assets/js/bootstrap.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1231,7 +1231,7 @@
12311231
, trigger: 'hover'
12321232
, title: ''
12331233
, delay: 0
1234-
, html: true
1234+
, html: false
12351235
}
12361236

12371237
}(window.jQuery);

docs/assets/js/bootstrap.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/bootstrap-tooltip.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
, trigger: 'hover'
270270
, title: ''
271271
, delay: 0
272-
, html: true
272+
, html: false
273273
}
274274

275275
}(window.jQuery);

js/tests/unit/bootstrap-tooltip.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,11 @@ $(function () {
3737
tooltip.tooltip('hide')
3838
})
3939

40-
test("should always allow html entities", function () {
40+
test("should allow html entities", function () {
4141
$.support.transition = false
4242
var tooltip = $('<a href="#" rel="tooltip" title="<b>@fat</b>"></a>')
4343
.appendTo('#qunit-fixture')
44+
.tooltip({html: true})
4445
.tooltip('show')
4546

4647
ok($('.tooltip b').length, 'b tag was inserted')

0 commit comments

Comments
 (0)
0