8000 example_recursive.rb breaks .xlsx file · Issue #343 · rubyzip/rubyzip · GitHub
[go: up one dir, main page]
Skip to content

example_recursive.rb breaks .xlsx file #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davetapley opened this issue Nov 9, 2017 · 4 comments
Closed

example_recursive.rb breaks .xlsx file #343

davetapley opened this issue Nov 9, 2017 · 4 comments

Comments

@davetapley
Copy link

When opening a .xlsx file zipped via example_recursive.rb in Excel 15.39 on Mac OS, I am presented with:

broken-xlsx

Clicking through to the error log I see:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<recoveryLog xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main">

<logFileName>Repair Result to SOME_FILE.xml</logFileName><summary>Errors were detected in file 'SOME_FILE.xlsx'</summary>

<additionalInfo><info>Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded.</info></additionalInfo>

</recoveryLog>

Not fixed by #260, not sure if related to https://github.com/rubyzip/rubyzip#modify-docx-file-with-rubyzip ?
@davetapley
Copy link
Author
davetapley commented Nov 9, 2017 •
edited
Loading

My files were nested at most one folder deep, so I just rolled by own implementation.
Only obvious difference is that I used zip_file.add file_name, file_path, whereas example_recursive.rb uses get_output_stream and write.

@lanrion
Copy link
lanrion commented Jan 23, 2018

+1

1 similar comment
@qwlong
Copy link
qwlong commented May 21, 2018

+1

@jdleesmiller
Copy link
Member

I think this was fixed in #297, which used the approach mentioned in #343 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davetapley @jdleesmiller @qwlong @lanrion
0