Add tests from #182 for testing tempfile as IO for OutputStream::write_buffer

simonoff · simonoff · commit 002959f2e2e5 · 2015-02-02T23:40:52.000+02:00
diff --git a/test/file_test.rb b/test/file_test.rb
@@ -535,10 +535,12 @@ def test_streaming
     end
 
     data = nil
-    Zip::File.open_buffer(File.binread(zname)) do |zipfile|
-      zipfile.each do |entry|
-        next unless entry.name =~ /README.md/
-        data = zipfile.read(entry)
+    File.open(zname, 'rb') do |f|
+      Zip::File.open_buffer(f) do |zipfile|
+        zipfile.each do |entry|
+          next unless entry.name =~ /README.md/
+          data = zipfile.read(entry)
+        end
       end
     end
     assert data
diff --git a/test/output_stream_test.rb b/test/output_stream_test.rb
@@ -32,6 +32,21 @@ def test_write_buffer
     assert_test_zip_contents(TEST_ZIP)
   end
 
+  def test_write_buffer_with_temp_file
+    tmp_file = Tempfile.new('')
+
+    ::Zip::OutputStream.write_buffer(tmp_file) do |zos|
+      zos.comment = TEST_ZIP.comment
+      write_test_zip(zos)
+    end
+
+    tmp_file.rewind
+    File.open(TEST_ZIP.zip_name, 'wb') { |f| f.write(tmp_file.read) }
+    tmp_file.unlink
+
+    assert_test_zip_contents(TEST_ZIP)
+  end
+
   def test_writingToClosedStream
     assert_i_o_error_in_closed_stream { |zos| zos << "hello world" }
     assert_i_o_error_in_closed_stream { |zos| zos.puts "hello world" }
