8000 Test with updated RBS gem which comes with new pure C parser by soutaro · Pull Request #13237 · ruby/ruby · GitHub
[go: up one dir, main page]
Skip to content

Test with updated RBS gem which comes with new pure C parser #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Test with updated RBS gem which comes with new pure C parser #13237

wants to merge 6 commits into from

Conversation

soutaro
Copy link
Member
@soutaro soutaro commented May 2, 2025

This is to confirm the new pure C parser implemented in ruby/rbs#2398 compiles in Ruby CI setting. This will break other bundled gems because RBS 4.0 has some breaking API changes.

@soutaro soutaro mentioned this pull request May 2, 2025
Merged
@soutaro soutaro changed the title Test new pure C parser Test with updated RBS gem which comes with new pure C parser May 2, 2025
@soutaro soutaro mentioned this pull request May 2, 2025
Merged
@soutaro
Copy link
Member Author
soutaro commented May 9, 2025

@Morriar @amomchilov @st0012 Can you help me to fix the compilation error?

https://github.com/ruby/ruby/actions/runs/14920483030/job/41914755919?pr=13237#step:5:1757

  /github/workspace/src/.bundle/gems/rbs-4.0.0.dev.2/ext/rbs_extension/../../src/util/rbs_allocator.c:53:39: error: use of undeclared identifier 'MAP_ANONYMOUS'
     53 |                         MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
        |                                       ^
  1 error generated.

Why MAP_ANONYMOUS is unavailable...??

@Morriar Morriar mentioned this pull request May 9, 2025
Merged
@Morriar
Copy link
Contributor
Morriar commented May 9, 2025

It looks like MAP_ANONYMOUS is not available. I though it was POSIX 🤔

We may need to provide a fallback. Working on a fix in ruby/rbs#2470.

@soutaro
Copy link
Member Author
soutaro commented May 9, 2025

Hmm. It might be reasonable. Will review and test the PR, next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soutaro @Morriar
0