[PRISM] Fix memory leak of ST table

peterzhu2118 · peterzhu2118 · commit 947194aacb3b · 2024-01-17T11:35:30.000-05:00
This commit fixes a memory leak in rb_translate_prism because the ST
table is never freed. There are still more memory leaks which still need
to be fixed.

For example:

    10.times do
      100_000.times do
        RubyVM::InstructionSequence.compile_prism("")
      end

      puts `ps -o rss= -p #{$$}`
    end

Before:

    34544
    57120
    79360
    102176
    123712
    146320
    168192
    190592
    212192
    234896

After:

    18336
    24592
    31488
    37648
    44592
    50944
    57280
    63632
    69904
    76160
diff --git a/prism_compile.c b/prism_compile.c
@@ -6936,6 +6936,8 @@ rb_translate_prism(pm_parser_t *parser, rb_iseq_t *iseq, pm_scope_node_t *scope_
     pm_compile_node(iseq, (pm_node_t *)scope_node, ret, scope_node->base.location.start, false, (pm_scope_node_t *)scope_node);
     iseq_set_sequence(iseq, ret);
 
+    st_free_table(index_lookup_table);
+
     return Qnil;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6936,6 +6936,8 @@ rb_translate_prism(pm_parser_t parser, rb_iseq_t iseq, pm_scope_node_t *scope_`
`6936`	`6936`	`pm_compile_node(iseq, (pm_node_t )scope_node, ret, scope_node->base.location.start, false, (pm_scope_node_t )scope_node);`
`6937`	`6937`	`iseq_set_sequence(iseq, ret);`
`6938`	`6938`
	`6939`	`+ st_free_table(index_lookup_table);`
	`6940`	`+`
`6939`	`6941`	`return Qnil;`
`6940`	`6942`	`}`
`6941`	`6943`