Fixed a memory leak in BLE (issue espressif#4753) (espressif#4761)

ushiboy · ushiboy · web-flow · commit e831680a41d4 · 2021-02-16T01:50:24.000+02:00
* Fixed crash on delete after disconnect

* Fixed memory leak when getting characteristics

* Removed guard

Co-authored-by: ushiboy &lt;ushiboy.dev@gmail.com&gt;
diff --git a/libraries/BLE/src/BLEClient.cpp b/libraries/BLE/src/BLEClient.cpp
@@ -60,6 +60,7 @@ BLEClient::~BLEClient() {
 	   delete myPair.second;
 	}
 	m_servicesMap.clear();
+	m_servicesMapByInstID.clear();
 } // ~BLEClient
 
 
diff --git a/libraries/BLE/src/BLERemoteCharacteristic.cpp b/libraries/BLE/src/BLERemoteCharacteristic.cpp
@@ -52,6 +52,7 @@ BLERemoteCharacteristic::BLERemoteCharacteristic(
  */
 BLERemoteCharacteristic::~BLERemoteCharacteristic() {
 	removeDescriptors();   // Release resources for any descriptor information we may have allocated.
+	free(m_rawData);
 } // ~BLERemoteCharacteristic
 
 

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ BLEClient::~BLEClient() {`
`60`	`60`	`delete myPair.second;`
`61`	`61`	`}`
`62`	`62`	`m_servicesMap.clear();`
	`63`	`+ m_servicesMapByInstID.clear();`
`63`	`64`	`} // ~BLEClient`
`64`	`65`
`65`	`66`