Fix issue espressif#5507 "Constructor WebServer::WebServer(IPAddress addr, int port) produces an unexpected result"

timr49 · timr49 · commit bee1e7088cef · 2021-08-08T18:24:49.000+10:00
"The class Webserver is declared with two explicit constructors, one with signature:
WebServer::WebServer(IPAddress addr, int port)
Using this results in a server listening on the port number obtained by converting the value of the IPAddress addr argument (in host byte order) to a uint32_t and then to a uint16_t, which is manifestly not the result that would be expected.
...
As for a fix, we can assume from these results that this constructor is not being used and therefore could simply be deleted."
diff --git a/libraries/WebServer/src/WebServer.cpp b/libraries/WebServer/src/WebServer.cpp
@@ -39,28 +39,6 @@ static const char WWW_Authenticate[] = "WWW-Authenticate";
 static const char Content_Length[] = "Content-Length";
 
 
-WebServer::WebServer(IPAddress addr, int port)
-: _corsEnabled(false)
-, _server(addr, port)
-, _currentMethod(HTTP_ANY)
-, _currentVersion(0)
-, _currentStatus(HC_NONE)
-, _statusChange(0)
-, _nullDelay(true)
-, _currentHandler(nullptr)
-, _firstHandler(nullptr)
-, _lastHandler(nullptr)
-, _currentArgCount(0)
-, _currentArgs(nullptr)
-, _postArgsLen(0)
-, _postArgs(nullptr)
-, _headerKeysCount(0)
-, _currentHeaders(nullptr)
-, _contentLength(0)
-, _chunked(false)
-{
-}
-
 WebServer::WebServer(int port)
 : _corsEnabled(false)
 , _server(port)
diff --git a/libraries/WebServer/src/WebServer.h b/libraries/WebServer/src/WebServer.h
@@ -70,7 +70,6 @@ class FS;
 class WebServer
 {
 public:
-  WebServer(IPAddress addr, int port = 80);
   WebServer(int port = 80);
   virtual ~WebServer();
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,6 @@ class FS;`
`70`	`70`	`class WebServer`
`71`	`71`	`{`
`72`	`72`	`public:`
`73`		`- WebServer(IPAddress addr, int port = 80);`
`74`	`73`	`WebServer(int port = 80);`
`75`	`74`	`virtual ~WebServer();`
`76`	`75`