8000 On OS X, link libpython normally, ignoring the "framework" framework. · rtpg/postgres@ae41bb4 · GitHub
[go: up one dir, main page]

Skip to content

Commit ae41bb4

Browse files
committed
On OS X, link libpython normally, ignoring the "framework" framework.
As of Xcode 5.0, Apple isn't including the Python framework as part of the SDK-level files, which means that linking to it might fail depending on whether Xcode thinks you've selected a specific SDK version. According to their Tech Note 2328, they've basically deprecated the framework method of linking to libpython and are telling people to link to the shared library normally. (I'm pretty sure this is in direct contradiction to the advice they were giving a few years ago, but whatever.) Testing says that this approach works fine at least as far back as OS X 10.4.11, so let's just rip out the framework special case entirely. We do still need a special case to decide that OS X provides a shared library at all, unfortunately (I wonder why the distutils check doesn't work ...). But this is still less of a special case than before, so it's fine. Back-patch to all supported branches, since we'll doubtless be hearing about this more as more people update to recent Xcode.
1 parent fd78544 commit ae41bb4

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/pl/plpython/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,9 @@ python_includespec := $(subst \,/,$(python_includespec))
2121
override python_libspec =
2222
endif
2323

24-
# Darwin (OS X) has its own ideas about how to do this.
24+
# Darwin (OS X) does supply a .dylib, but the above test doesn't match that.
2525
ifeq ($(PORTNAME), darwin)
2626
shared_libpython = yes
27-
override python_libspec = -framework Python
28-
override python_additional_libs =
2927
endif
3028

3129
# If we don't have a shared library and the platform doesn't allow it

0 commit comments

Comments
 (0)
0