FIX Fix memory leak in liblinear helper csr_to_sparse error path (scikit-learn#14118)

alexhenrie · jnothman · commit 8632775c23a3 · 2019-06-20T10:43:54.000+10:00
diff --git a/sklearn/svm/src/liblinear/liblinear_helper.c b/sklearn/svm/src/liblinear/liblinear_helper.c
@@ -87,10 +87,10 @@ static struct feature_node **csr_to_sparse(double *values,
 
         sparse[i] = malloc ((n+have_bias+1) * sizeof(struct feature_node));
         if (sparse[i] == NULL) {
-            int l;
-            for (l=0; l<i; l++)
-                free(sparse[l]);
-            break;
+            for (j=0; j<i; ++j)
+                free(sparse[j]);
+            free(sparse);
+            return NULL;
         }
 
         temp = sparse[i];
