8000 Vertical align mismatch between inserted/deleted text and matching · Issue #487 · rtfpessoa/diff2html · GitHub
[go: up one dir, main page]
Skip to content

Vertical align mismatch between inserted/deleted text and matching #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandondong opened this issue Apr 5, 2023 · 0 comments · Fixed by #488
Closed

Vertical align mismatch between inserted/deleted text and matching #487

brandondong opened this issue Apr 5, 2023 · 0 comments · Fixed by #488

Comments

@brandondong
Copy link

Step 0: Describe your environment

  • OS: Windows
  • diff2html version: 3.4.34
  • Using diff2html directly
  • Extra flags: None

Step 1: Describe the problem:

Inserted/deleted text sinks slightly below matching text. Notice in this screenshot of the demo page how the parenthesis don't line up exactly:
image

Steps to reproduce:

  1. Navigate to the demo page and zoom into the scripts/hulk.js example.

Expected Results:

  • Text baselines should match.

Relevant Code:

If

diff2html/src/ui/css/diff2html.css

Line 159 in 2c7e03d

vertical-align: middle;
(and ins) is changed to vertical-align: baseline; or just removed, then this should work as expected. Not exactly sure why the middle alignment was added in the first place. I can see it was added in #348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix vertical align on diff rtfpessoa/diff2html
1 participant
@brandondong
0