8000 File content toggle (checkbox) should not be rendered when using `Diff2Html` only · Issue #364 · rtfpessoa/diff2html · GitHub
[go: up one dir, main page]
Skip to content

File content toggle (checkbox) should not be rendered when using Diff2Html only #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pierrci opened this issue Feb 24, 2021 · 1 comment · Fixed by #366
Closed

File content toggle (checkbox) should not be rendered when using Diff2Html only #364

Pierrci opened this issue Feb 24, 2021 · 1 comment · Fixed by #366

Comments

@Pierrci
Copy link
Contributor
Pierrci commented Feb 24, 2021

Step 0: Describe your environment

  • OS: MacOS
  • diff2html version: 3.2.0
  • Using diff2html directly or using diff2html-ui helper: diff2html
  • Extra flags: _

Step 1: Describe the problem:

Steps to reproduce:

  1. Call Diff2html.html on any diff

Observed Results:

  • A checkbox to toggle the content of the diff is rendered for each file

Expected Results:

  • When using Diff2Html only, there is no JS to listen to events and to update the view when the checkbox is clicked. Thus, it should rather behave the same way as the fileListToggle option of Diff2HtmlUI for example, and not render the checkbox at all.
@Pierrci Pierrci mentioned this issue Mar 1, 2021
Merged
@rtfpessoa
Copy link
Owner

Released in https://github.com/rtfpessoa/diff2html/releases/tag/3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only display "Viewed" checkbox if fileContentToggle is set huggingface/diff2html
2 participants
@rtfpessoa @Pierrci
0