8000 Merge pull request #2178 from rspec/fix-bad-negation · rspec/rspec-rails@203e893 · GitHub
[go: up one dir, main page]

Skip to content

Commit 203e893

Browse files
authored
Merge pull request #2178 from rspec/fix-bad-negation
Fix bad negation in functions
2 parents fc2ed90 + bc09eae commit 203e893

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

script/predicate_functions.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ function is_mri_192 {
3333
fi
3434
}
3535

36-
function is_mri_193 {
36+
function is_not_mri_193 {
3737
if is_mri; then
3838
if ruby -e "exit(RUBY_VERSION == '1.9.3')"; then
39-
return 0
40-
else
4139
return 1
40+
else
41+
return 0
4242
fi
4343
else
44-
return 1
44+
return 0
4545
fi
4646
}
4747

script/run_build

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,10 @@ fi
3131
if is_mri; then
3232
# As of 2019-09-24 this causes a huge log due to a cicular dependency
3333
# disable for now
34-
if !is_mri_193; then
34+
if is_not_mri_193; then
3535
fold "one-by-one specs" run_specs_one_by_one
36+
else
37+
echo "Skipping one-by-one specs due to issue on 1.9.3"
3638
fi
3739
run_all_spec_suites
3840
else

0 commit comments

Comments
 (0)
0