Merge pull request microsoft#149 from Microsoft/daveta-fix-waterfall

axelsrz · web-flow · commit a40a09678f7e · 2019-05-01T13:14:33.000-07:00
Fix waterfall test (add accessor set)
diff --git a/libraries/botbuilder-applicationinsights/tests/test_telemetry_waterfall.py b/libraries/botbuilder-applicationinsights/tests/test_telemetry_waterfall.py
@@ -23,6 +23,7 @@
 from botbuilder.dialogs import (
                                 Dialog,
                                 DialogSet,
+                                DialogState,
                                 WaterfallDialog,
                                 WaterfallStepContext,
                                 DialogTurnResult,
@@ -45,8 +46,8 @@ def test_none_telemetry_client(self):
         # assert
         self.assertEqual(type(dialog.telemetry_client), NullTelemetryClient)
 
-    @skip('Pending Telemetry mock')
-    @patch('test_telemetry_waterfall.ApplicationInsightsTelemetryClient')
+
+    @patch('botbuilder.applicationinsights.ApplicationInsightsTelemetryClient')
     async def test_execute_sequence_waterfall_steps(self, MockTelemetry):
         # arrange
 
@@ -56,7 +57,7 @@ async def test_execute_sequence_waterfall_steps(self, MockTelemetry):
         
         
         # Create a DialogState property, DialogSet and register the WaterfallDialog.
-        dialog_state = convo_state.create_property('dialogState')
+        dialog_state = convo_state.create_property('dialogState') 
         dialogs = DialogSet(dialog_state)
         async def step1(step) -> DialogTurnResult:
             await step.context.send_activity('bot responding.')
@@ -82,6 +83,8 @@ async def exec_test(turn_context: TurnContext) -> None:
             else:
                 if results.status == DialogTurnStatus.Complete:
                     await turn_context.send_activity(results.result)
+            
+            await dialog_state.set(turn_context, DialogState(dc.stack))
             await convo_state.save_changes(turn_context)
             
         adapt = TestAdapter(exec_test)
@@ -100,8 +103,8 @@ async def exec_test(turn_context: TurnContext) -> None:
                             ]
         self.assert_telemetry_calls(telemetry, telemetry_calls)
 
-    @skip('Pending Telemetry mock')     
-    @patch('test_telemetry_waterfall.ApplicationInsightsTelemetryClient')
+    
+    @patch('botbuilder.applicationinsights.ApplicationInsightsTelemetryClient')
     async def test_ensure_end_dialog_called(self, MockTelemetry):
         # arrange
 
@@ -134,6 +137,7 @@ async def exec_test(turn_context: TurnContext) -> None:
             results = await dc.continue_dialog()
             if turn_context.responded == False:
                 await dc.begin_dialog("test", None)
+            await dialog_state.set(turn_context, DialogState(dc.stack))
             await convo_state.save_changes(turn_context)
             
         adapt = TestAdapter(exec_test)
