8000 feat: Convert custom_attribute_condition_evaluator to TS (#561) · rserrano-eSW/javascript-sdk@f9d96e6 · GitHub
[go: up one dir, main page]
Skip to content

Commit f9d96e6

Browse files
yavoronayavorona
authored
feat: Convert custom_attribute_condition_evaluator to TS (optimizely#561)
* Convert custom_attribute_condition_evaluator to TS * Add to do and clean up * Create shares_types.ts to store UserAttributes and Condition types in * Fix spacing * Imcorporate Matt's comment part 1 * Incorporate Matt's comments part 2 * Revise evaluate function * Add null to condition value type
1 parent 80b4108 commit f9d96e6

File tree

6 files changed

+569
-516
lines changed

6 files changed

+569
-516
lines changed

‎packages/optimizely-sdk/lib/core/audience_evaluator/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
ERROR_MESSAGES,
2424
} from '../../utils/enums';
2525
import conditionTreeEvaluator from '../condition_tree_evaluator';
26-
import customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
26+
import * as customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
2727

2828
var logger = getLogger();
2929
var MODULE_NAME = 'AUDIENCE_EVALUATOR';

‎packages/optimizely-sdk/lib/core/audience_evaluator/index.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { getLogger } from '@optimizely/js-sdk-logging';
1919

2020
import AudienceEvaluator from './index';
2121
import conditionTreeEvaluator from '../condition_tree_evaluator';
22-
import customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
22+
import * as customAttributeConditionEvaluator from '../custom_attribute_condition_evaluator';
2323

2424
var mockLogger = getLogger();
2525

‎packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js

Lines changed: 0 additions & 304 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0