8000 1. Reverted changes from logging package. · rserrano-eSW/javascript-sdk@f3df4a1 · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f3df4a1

Browse files
committed
1. Reverted changes from logging package.
2. Added ReactNative logger in optimizely-sdk package.
1 parent 5d97c0c commit f3df4a1

File tree

3 files changed

+29
-19
lines changed

3 files changed

+29
-19
lines changed

packages/logging/src/logger.ts

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export class ConsoleLogHandler implements LogHandler {
173173
* @param {string[]} logArguments
174174
* @memberof ConsoleLogger
175175
*/
176-
protected consoleLog(logLevel: LogLevel, logArguments: [string, ...string[]]) {
176+
private consoleLog(logLevel: LogLevel, logArguments: [string, ...string[]]) {
177177
switch (logLevel) {
178178
case LogLevel.DEBUG:
179179
console.log.apply(console, logArguments)
@@ -193,22 +193,6 @@ export class ConsoleLogHandler implements LogHandler {
193193
}
194194
}
195195

196-
export class ReactNativeConsoleLogHandler extends ConsoleLogHandler {
197-
/**
198-
* @private
199-
* @param {LogLevel} logLevel
200-
* @param {string[]} logArguments
201-
* @memberof ConsoleLogger
202-
*/
203-
protected consoleLog(logLevel: LogLevel, logArguments: [string, ...string[]]) {
204-
if (logLevel === LogLevel.ERROR) {
205-
console.warn.apply(console, logArguments);
206-
} else {
207-
super.consoleLog(logLevel, logArguments);
208-
}
209-
}
210-
}
211-
212196
let globalLogLevel: LogLevel = LogLevel.NOTSET
213197
let globalLogHandler: LogHandler | null = null
214198

packages/optimizely-sdk/lib/index.react_native.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
var logging = require('@optimizely/js-sdk-logging');
16+
var Logger = require('./plugins/logger/index.react_native');
1717
var browserIndex = require('./index.browser');
1818

1919
/**
@@ -37,7 +37,7 @@ module.exports = {
3737
*/
3838
createInstance: function(config) {
3939
return browserIndex.createInstance({
40-
logger: new logging.ReactNativeConsoleLogHandler(),
40+
logger: new Logger(),
4141
...config,
4242
})
4343
}
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
var LogLevel = require('@optimizely/js-sdk-logging').LogLevel;
2+
3+
function getLogLevelName(level) {
4+
switch(level) {
5+
case LogLevel.INFO: return 'INFO';
6+
case LogLevel.ERROR: return 'ERROR';
7+
case LogLevel.WARNING: return 'WARNING';
8+
case LogLevel.DEBUG: return 'DEBUG';
9+
default: return 'NOTSET';
10+
}
11+
}
12+
13+
export default class ReactNativeLogger {
14+
log(level, message) {
15+
const formattedMessage = `[OPTIMIZELY] - ${getLogLevelName(level)} ${new Date().toISOString()} ${message}`;
16+
switch (level) {
17+
case LogLevel.INFO: console.info(formattedMessage); break;
18+
case LogLevel.ERROR:
19+
case LogLevel.WARNING: console.warn(formattedMessage); break;
20+
case LogLevel.DEBUG:
21+
case LogLevel.NOTSET: console.log(formattedMessage); break;
22+
}
23+
}
24+
}
25+
26+
module.exports = ReactNativeLogger;

0 commit comments

Comments
 (0)
0