10000 Remove user Id validation from project_config. · rserrano-eSW/javascript-sdk@8000267 · GitHub
[go: up one dir, main page]
Skip to content

Commit 8000267

Browse files
mfahadahmedmfahadahmed
committed
Remove user Id validation from project_config.
1 parent bd7eb75 commit 8000267

File tree

3 files changed

+5
-20
lines changed

3 files changed

+5
-20
lines changed

‎packages/optimizely-sdk/lib/core/project_config/index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -338,10 +338,6 @@ module.exports = {
338338
* @throws If the user id is not valid
339339
*/
340340
setInForcedVariationMap: function(projectConfig, userId, experimentId, variationId, logger) {
341-
if (!userId) {
342-
throw new Error(sprintf(ERROR_MESSAGES.INVALID_USER_ID, MODULE_NAME));
343-
}
344-
345341
if (projectConfig.forcedVariationMap.hasOwnProperty(userId)) {
346342
projectConfig.forcedVariationMap[userId][experimentId] = variationId;
347343
} else {

‎packages/optimizely-sdk/lib/core/project_config/index.tests.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -726,22 +726,6 @@ describe('lib/core/project_config', function() {
726726
assert.strictEqual(variation2, 'controlLaunched');
727727
});
728728

729-
it('should return false for a null userId', function() {
730-
var testData = testDatafile.getTestProjectConfig();
731-
var configObj = projectConfig.createProjectConfig(testData);
732-
733-
var didSetVariation = projectConfig.setForcedVariation(configObj, 'testExperiment', null, 'control', createdLogger);
734-
assert.strictEqual(didSetVariation, false);
735-
});
736-
737-
it('should return false for an undefined userId', function() {
738-
var testData = testDatafile.getTestProjectConfig();
739-
var configObj = projectConfig.createProjectConfig(testData);
740-
741-
var didSetVariation = projectConfig.setForcedVariation(configObj, 'testExperiment', undefined, 'control', createdLogger);
742-
assert.strictEqual(didSetVariation, false);
743-
});
744-
745729
it('should return false for an empty variation key', function() {
746730
var testData = testDatafile.getTestProjectConfig();
747731
var configObj = projectConfig.createProjectConfig(testData);

‎packages/optimizely-sdk/lib/optimizely/index.tests.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1915,6 +1915,11 @@ describe('lib/optimizely', function() {
19151915
assert.strictEqual(setVariationLogMessage, sprintf(ERROR_MESSAGES.INVALID_INPUT_FORMAT, 'OPTIMIZELY', 'user_id'));
19161916
});
19171917

1918+
it('should return true for an empty userId', function() {
1919+
var didSetVariation = optlyInstance.setForcedVariation('testExperiment', '', 'control');
1920+
assert.strictEqual(didSetVariation, true);
1921+
});
1922+
19181923
it('should return false for a null variationKey', function() {
19191924
var didSetVariation = optlyInstance.setForcedVariation('testExperiment', 'user1', null);
19201925
assert.strictEqual(didSetVariation, false);

0 commit comments

Comments
 (0)
0