8000 Merge pull request #1896 from dhalbert/round-int-4.0.x · rsbohn/circuitpython@70e0b5c · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 70e0b5c

Browse files
authored
Merge pull request adafruit#1896 from dhalbert/round-int-4.0.x
Enable MICROPY_PY_BUILTINS_ROUND_INT; make round() work better when flag is disabled
2 parents aae7cb3 + 0199d98 commit 70e0b5c

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

ports/atmel-samd/boards/circuitplayground_express/mpconfigboard.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Thermistor
2727

2828
# Tweak inlining depending on language.
2929
ifeq ($(TRANSLATION), zh_Latn_pinyin)
30-
CFLAGS_INLINE_LIMIT = 35
30+
CFLAGS_INLINE_LIMIT = 25
3131
else
3232
CFLAGS_INLINE_LIMIT = 55
3333
endif

py/circuitpy_mpconfig.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
#define MICROPY_PY_BUILTINS_MIN_MAX (1)
9090
#define MICROPY_PY_BUILTINS_PROPERTY (1)
9191
#define MICROPY_PY_BUILTINS_REVERSED (1)
92+
#define MICROPY_PY_BUILTINS_ROUND_INT (1)
9293
#define MICROPY_PY_BUILTINS_SET (1)
9394
#define MICROPY_PY_BUILTINS_SLICE (1)
9495
#define MICROPY_PY_BUILTINS_SLICE_ATTRS (1)

py/modbuiltins.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -455,13 +455,13 @@ STATIC mp_obj_t mp_builtin_round(size_t n_args, const mp_obj_t *args) {
455455
return o_in;
456456
}
457457

458-
#if !MICROPY_PY_BUILTINS_ROUND_INT
459-
mp_raise_NotImplementedError(NULL);
460-
#else
461458
mp_int_t num_dig = mp_obj_get_int(args[1]);
462459
if (num_dig >= 0) {
463460
return o_in;
464461
}
462+
#if !MICROPY_PY_BUILTINS_ROUND_INT
463+
mp_raise_NotImplementedError(NULL);
464+
#else
465465

466466
mp_obj_t mult = mp_binary_op(MP_BINARY_OP_POWER, MP_OBJ_NEW_SMALL_INT(10), MP_OBJ_NEW_SMALL_INT(-num_dig));
467467
mp_obj_t half_mult = mp_binary_op(MP_BINARY_OP_FLOOR_DIVIDE, mult, MP_OBJ_NEW_SMALL_INT(2));

0 commit comments

Comm 317A ents
 (0)
0