This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Draft: use Ed25519 instead of RSA by default, drop openssl dep #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
|
Nice, the CI seems to agree with this approach; I'll just force-push the removal of |
5963223 to
d0910ab
Compare
|
More than a year passed... Please merge this finally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at the upcoming
go-ipfs 0.7changes, the one that stood out to me most was the switch from RSA to Ed25519 keys by default; since the only reason why we're shippingopensslis that we be default generate RSA keys, this seemed to me like a good opportunity to ditch it and free ourselves from one of the trickiest dependencies.Since I might have been a bit "heavy-handed" in the way I handled these changes and since they are quite severe, I'm posting it as a draft so that we can discuss this further, see how the CI changes fare etc. There's some work left wrt updating the README etc., but "the meat" is already here.
This would obviate #128.
Cc #170, #96