Port auth error handling from microsoft_app_credentials to certificate_app_credentials (microsoft#2196)

kostyaplis · Konstantin Plis · web-flow · commit ef5ecd36f765 · 2025-01-06T09:54:12.000-06:00
Co-authored-by: Konstantin Plis &lt;konstantin.plis@acronis.com&gt;
diff --git a/libraries/botframework-connector/botframework/connector/auth/certificate_app_credentials.py b/libraries/botframework-connector/botframework/connector/auth/certificate_app_credentials.py
@@ -67,7 +67,17 @@ def get_access_token(self, force_refresh: bool = False) -> str:
         if not auth_token:
             # No suitable token exists in cache. Let's get a new one from AAD.
             auth_token = self.__get_msal_app().acquire_token_for_client(scopes=scopes)
-        return auth_token["access_token"]
+        if "access_token" in auth_token:
+            return auth_token["access_token"]
+        error = auth_token["error"] if "error" in auth_token else "Unknown error"
+        error_description = (
+            auth_token["error_description"]
+            if "error_description" in auth_token
+            else "Unknown error description"
+        )
+        raise PermissionError(
+            f"Failed to get access token with error: {error}, error_description: {error_description}"
+        )
 
     def __get_msal_app(self):
         if not self.app:
