mnist: fix segmentation fault (ggml/1227)

JohannesGaessler · ggerganov · commit 6c35981a643d · 2025-05-19T13:29:56.000+03:00
diff --git a/ggml/include/ggml-opt.h b/ggml/include/ggml-opt.h
@@ -128,6 +128,8 @@ extern "C" {
     // set gradients to zero, initilize loss, and optionally reset the optimizer
     GGML_API void ggml_opt_reset(ggml_opt_context_t opt_ctx, bool optimizer);
 
+    GGML_API bool ggml_opt_static_graphs(ggml_opt_context_t opt_ctx); // whether the graphs are allocated_statically
+
     // get underlying tensors that store data
     // if not using static graphs these pointers become invalid with the next call to ggml_opt_alloc
     GGML_API struct ggml_tensor * ggml_opt_inputs(  ggml_opt_context_t opt_ctx); // forward graph input tensor
diff --git a/ggml/src/ggml-opt.cpp b/ggml/src/ggml-opt.cpp
@@ -576,6 +576,10 @@ void ggml_opt_reset(ggml_opt_context_t opt_ctx, bool optimizer) {
     }
 }
 
+bool ggml_opt_static_graphs(ggml_opt_context_t opt_ctx) {
+    return opt_ctx->static_graphs;
+}
+
 struct ggml_tensor * ggml_opt_inputs(ggml_opt_context_t opt_ctx) {
     return opt_ctx->inputs;
 }
@@ -842,6 +846,7 @@ void ggml_opt_epoch(
         int64_t                 idata_split,
         ggml_opt_epoch_callback callback_train,
         ggml_opt_epoch_callback callback_eval) {
+    GGML_ASSERT(ggml_opt_static_graphs(opt_ctx) && "ggml_opt_epoch requires static graphs");
     struct ggml_tensor * inputs = ggml_opt_inputs(opt_ctx);
     struct ggml_tensor * labels = ggml_opt_labels(opt_ctx);
     struct ggml_tensor * data   = ggml_opt_dataset_data(dataset);

Original file line number	Diff line number	Diff line change
`@@ -576,6 +576,10 @@ void ggml_opt_reset(ggml_opt_context_t opt_ctx, bool optimizer) {`
`576`	`576`	`}`
`577`	`577`	`}`
`578`	`578`
	`579`	`+bool ggml_opt_static_graphs(ggml_opt_context_t opt_ctx) {`
	`580`	`+ return opt_ctx->static_graphs;`
	`581`	`+}`
	`582`	`+`
`579`	`583`	`struct ggml_tensor * ggml_opt_inputs(ggml_opt_context_t opt_ctx) {`
`580`	`584`	`return opt_ctx->inputs;`
`581`	`585`	`}`
`@@ -842,6 +846,7 @@ void ggml_opt_epoch(`
`842`	`846`	`int64_t idata_split,`
`843`	`847`	`ggml_opt_epoch_callback callback_train,`
`844`	`848`	`ggml_opt_epoch_callback callback_eval) {`
	`849`	`+ GGML_ASSERT(ggml_opt_static_graphs(opt_ctx) && "ggml_opt_epoch requires static graphs");`
`845`	`850`	`struct ggml_tensor * inputs = ggml_opt_inputs(opt_ctx);`
`846`	`851`	`struct ggml_tensor * labels = ggml_opt_labels(opt_ctx);`
`847`	`852`	`struct ggml_tensor * data = ggml_opt_dataset_data(dataset);`