fix(Serializer): Do not use class-string type-hint it breaks JSON serializer symfony/symfony#47736

ambroisemaupate · ambroisemaupate · commit 9ffaf6e550ac · 2023-09-29T14:30:38.000+02:00
diff --git a/config/packages/messenger.yaml b/config/packages/messenger.yaml
@@ -4,7 +4,11 @@ framework:
         # failure_transport: failed
         reset_on_message: true
         transports:
-            async: '%env(MESSENGER_TRANSPORT_DSN)%'
+            # https://symfony.com/doc/current/messenger.html#transport-configuration
+            async:
+                dsn: '%env(MESSENGER_TRANSPORT_DSN)%'
+                # Use JSON message to be able to decode them in a NodeJS worker
+                serializer: messenger.transport.symfony_serializer
             failed: 'doctrine://default?queue_name=failed'
             sync: 'sync://'
 
diff --git a/lib/RoadizCoreBundle/src/SearchEngine/Message/AbstractSolrMessage.php b/lib/RoadizCoreBundle/src/SearchEngine/Message/AbstractSolrMessage.php
@@ -9,7 +9,8 @@
 abstract class AbstractSolrMessage implements AsyncMessage
 {
     /**
-     * @var class-string
+     * Cannot typehint with class-string: breaks Symfony Serializer 5.4
+     * @var string
      */
     protected string $classname;
     /**
@@ -18,7 +19,7 @@ abstract class AbstractSolrMessage implements AsyncMessage
     protected mixed $identifier;
 
     /**
-     * @param class-string $classname
+     * @param string $classname
      * @param mixed $identifier
      */
     public function __construct(string $classname, mixed $identifier)
@@ -28,7 +29,7 @@ public function __construct(string $classname, mixed $identifier)
     }
 
     /**
-     * @return class-string
+     * @return string
      */
     public function getClassname(): string
     {
diff --git a/lib/RoadizCoreBundle/src/SearchEngine/Message/Handler/SolrDeleteMessageHandler.php b/lib/RoadizCoreBundle/src/SearchEngine/Message/Handler/SolrDeleteMessageHandler.php
@@ -25,6 +25,8 @@ public function __invoke(SolrDeleteMessage $message): void
     {
         try {
             if (!empty($message->getIdentifier())) {
+                // Cannot typehint with class-string: breaks Symfony Serializer 5.4
+                // @phpstan-ignore-next-line
                 $this->indexerFactory->getIndexerFor($message->getClassname())->delete($message->getIdentifier());
             }
         } catch (SolrServerNotAvailableException $exception) {
diff --git a/lib/RoadizCoreBundle/src/SearchEngine/Message/Handler/SolrReindexMessageHandler.php b/lib/RoadizCoreBundle/src/SearchEngine/Message/Handler/SolrReindexMessageHandler.php
@@ -25,6 +25,8 @@ public function __invoke(SolrReindexMessage $message): void
     {
         try {
             if (!empty($message->getIdentifier())) {
+                // Cannot typehint with class-string: breaks Symfony Serializer 5.4
+                // @phpstan-ignore-next-line
                 $this->indexerFactory->getIndexerFor($message->getClassname())->index($message->getIdentifier());
             }
         } catch (SolrServerNotAvailableException $exception) {

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@ public function __invoke(SolrDeleteMessage $message): void`
`25`	`25`	`{`
`26`	`26`	`try {`
`27`	`27`	`if (!empty($message->getIdentifier())) {`
	`28`	`+ // Cannot typehint with class-string: breaks Symfony Serializer 5.4`
	`29`	`+ // @phpstan-ignore-next-line`
`28`	`30`	`$this->indexerFactory->getIndexerFor($message->getClassname())->delete($message->getIdentifier());`
`29`	`31`	`}`
`30`	`32`	`} catch (SolrServerNotAvailableException $exception) {`