check if files exist.

rmehta19 · rmehta19 · commit 91175ef017d1 · 2024-11-12T09:35:55.000-08:00
diff --git a/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java b/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java
@@ -503,35 +503,45 @@ ChannelCredentials createS2ASecuredChannelCredentials() {
     // Currently, MTLS to MDS is only available on GCE. See:
     // https://cloud.google.com/compute/docs/metadata/overview#https-mds
     // Try to load MTLS-MDS creds.
-    InputStream trustBundle = null;
-    InputStream privateKey = null;
-    InputStream certChain = null;
-    try {
-      trustBundle = new FileInputStream(MTLS_MDS_ROOT);
-      privateKey = new FileInputStream(MTLS_MDS_CERT_CHAIN_AND_KEY);
-      certChain = new FileInputStream(MTLS_MDS_CERT_CHAIN_AND_KEY);
-    } catch (FileNotFoundException ignore) {
-      // Fallback to plaintext-to-S2A connection.
-      LOG.log(
-          Level.INFO,
-          "Cannot establish an mTLS connection to S2A due to error loading MTLS to MDS credentials, falling back to plaintext connection to S2A: "
-              + ignore.getMessage());
-      return createPlaintextToS2AChannelCredentials(plaintextAddress);
-    }
-    ChannelCredentials mtlsToS2AChannelCredentials = null;
-    try {
+    File rootFile = new File(MTLS_MDS_ROOT);
+    File certKeyFile = new File(MTLS_MDS_CERT_CHAIN_AND_KEY);
+    if (!rootFile.isFile() || !certKeyFile.isFile()) {
       // Try to connect to S2A using mTLS.
-      mtlsToS2AChannelCredentials =
-          createMtlsToS2AChannelCredentials(trustBundle, privateKey, certChain);
-    } catch (IOException ignore) {
-      // Fallback to plaintext-to-S2A connection.
+      ChannelCredentials mtlsToS2AChannelCredentials = null;
+      InputStream trustBundle = null;
+      InputStream privateKey = null;
+      InputStream certChain = null;
+      try {
+        trustBundle = new FileInputStream(MTLS_MDS_ROOT);
+        privateKey = new FileInputStream(MTLS_MDS_CERT_CHAIN_AND_KEY);
+        certChain = new FileInputStream(MTLS_MDS_CERT_CHAIN_AND_KEY);
+      } catch (FileNotFoundException ignore) {
+        // Fallback to plaintext-to-S2A connection on error.
+        LOG.log(
+            Level.INFO,
+            "Cannot establish an mTLS connection to S2A due to error loading MTLS to MDS credentials, falling back to plaintext connection to S2A: "
+                + ignore.getMessage());
+        return createPlaintextToS2AChannelCredentials(plaintextAddress);
+      }
+      try {
+        mtlsToS2AChannelCredentials =
+            createMtlsToS2AChannelCredentials(trustBundle, privateKey, certChain);
+      } catch (IOException ignore) {
+        // Fallback to plaintext-to-S2A connection on error.
+        LOG.log(
+            Level.WARNING,
+            "Cannot establish an mTLS connection to S2A due to error creating MTLS to MDS TlsChannelCredentials credentials, falling back to plaintext connection to S2A: "
+                + ignore.getMessage());
+        return createPlaintextToS2AChannelCredentials(plaintextAddress);
+      }
+      return S2AChannelCredentials.newBuilder(mtlsAddress, mtlsToS2AChannelCredentials).build();
+    } else {
+      // Fallback to plaintext-to-S2A connection if MTLS-MDS creds do not exist.
       LOG.log(
-          Level.WARNING,
-          "Cannot establish an mTLS connection to S2A due to error creating MTLS to MDS TlsChannelCredentials credentials, falling back to plaintext connection to S2A: "
-              + ignore.getMessage());
+          Level.INFO,
+          "Cannot establish an mTLS connection to S2A  MTLS to MDS credentials do not exist on filesystem, falling back to plaintext connection to S2A");
       return createPlaintextToS2AChannelCredentials(plaintextAddress);
     }
-    return S2AChannelCredentials.newBuilder(mtlsAddress, mtlsToS2AChannelCredentials).build();
   }
 
   private ManagedChannel createSingleChannel() throws IOException {
