Fix update datasource connection server port (tableau#283)

shinchris · web-flow · commit ad1be7d54ab5 · 2018-04-06T09:57:02.000-07:00
* addressing bug tableau#281: update datasource connection not updating server port properly
diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py
@@ -365,7 +365,7 @@ def update_req(self, xml_request, connection_item):
         if connection_item.server_address:
             connection_element.attrib['serverAddress'] = connection_item.server_address.lower()
         if connection_item.server_port:
-            connection_element.attrib['port'] = str(connection_item.server_port)
+            connection_element.attrib['serverPort'] = str(connection_item.server_port)
         if connection_item.username:
             connection_element.attrib['userName'] = connection_item.username
         if connection_item.password:
diff --git a/test/assets/datasource_connection_update.xml b/test/assets/datasource_connection_update.xml
@@ -2,4 +2,4 @@
 <tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
             xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.8.xsd">
     <connection id="be786ae0-d2bf-4a4b-9b34-e2de8d2d4488"
-                type="textscan" userName="foo"/></tsResponse>
+                type="textscan" serverAddress="bar" serverPort="9876" userName="foo"/></tsResponse>
diff --git a/test/test_datasource.py b/test/test_datasource.py
@@ -161,10 +161,14 @@ def test_update_connection(self):
             self.server.datasources.populate_connections(single_datasource)
 
             connection = single_datasource.connections[0]
+            connection.server_address = 'bar'
+            connection.server_port = '9876'
             connection.username = 'foo'
             new_connection = self.server.datasources.update_connection(single_datasource, connection)
             self.assertEqual(connection.id, new_connection.id)
             self.assertEqual(connection.connection_type, new_connection.connection_type)
+            self.assertEquals('bar', new_connection.server_address)
+            self.assertEquals('9876', new_connection.server_port)
             self.assertEqual('foo', new_connection.username)
 
     def test_publish(self):
