8000 adding project id field to view_item (#285) · rmagier1/server-client-python@728ec5c · GitHub
[go: up one dir, main page]
Skip to content

Commit 728ec5c

Browse files
shinchrisshinchris
authored
adding project id field to view_item (tableau#285)
1 parent df44535 commit 728ec5c

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

‎tableauserverclient/models/view_item.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ def __init__(self):
1111
self._name = None
1212
self._owner_id = None
1313
self._preview_image = None
14+
self._project_id = None
1415
self._pdf = None
1516
self._csv = None
1617
self._total_views = None
@@ -59,6 +60,10 @@ def preview_image(self):
5960
raise UnpopulatedPropertyError(error)
6061
return self._preview_image()
6162

63+
@property
64+
def project_id(self):
65+
return self._project_id
66+
6267
@property
6368
def pdf(self):
6469
if self._pdf is None:
@@ -97,6 +102,7 @@ def from_xml_element(cls, parsed_response, ns, workbook_id=''):
97102
usage_elem = view_xml.find('.//t:usage', namespaces=ns)
98103
workbook_elem = view_xml.find('.//t:workbook', namespaces=ns)
99104
owner_elem = view_xml.find('.//t:owner', namespaces=ns)
105+
project_elem = view_xml.find('.//t:project', namespaces=ns)
100106
view_item._id = view_xml.get('id', None)
101107
view_item._name = view_xml.get('name', None)
102108
view_item._content_url = view_xml.get('contentUrl', None)
@@ -107,10 +113,14 @@ def from_xml_element(cls, parsed_response, ns, workbook_id=''):
107113

108114
if owner_elem is not None:
109115
view_item._owner_id = owner_elem.get('id', None)
110-
all_view_items.append(view_item)
116+
117+
if project_elem is not None:
118+
view_item._project_id = project_elem.get('id', None)
111119

112120
if workbook_id:
113121
view_item._workbook_id = workbook_id
114122
elif workbook_elem is not None:
115123
view_item._workbook_id = workbook_elem.get('id', None)
124+
125+
all_view_items.append(view_item)
116126
return all_view_items

‎test/assets/view_get.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
<view id="d79634e1-6063-4ec9-95ff-50acbf609ff5" name="ENDANGERED SAFARI" contentUrl="SafariSample/sheets/ENDANGEREDSAFARI">
66
<workbook id="3cc6cd06-89ce-4fdc-b935-5294135d6d42" />
77
<owner id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" />
8+
<project id="5241e88d-d384-4fd7-9c2f-648b5247efc5" />
89
</view>
910
<view id="fd252f73-593c-4c4e-8584-c032b8022adc" name="Overview" contentUrl="Superstore/sheets/Overview">
1011
<workbook id="6d13b0ca-043d-4d42-8c9d-3f3313ea3a00" />
1112
<owner id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" />
13+
<project id="5b534f74-3226-11e8-b47a-cb2e00f738a3" />
1214
</view>
1315
</views>
1416
</tsResponse>

‎test/test_view.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,14 @@ def test_get(self):
3939
self.assertEqual('SafariSample/sheets/ENDANGEREDSAFARI', all_views[0].content_url)
4040
self.assertEqual('3cc6cd06-89ce-4fdc-b935-5294135d6d42', all_views[0].workbook_id)
4141
self.assertEqual('5de011f8-5aa9-4d5b-b991-f462c8dd6bb7', all_views[0].owner_id)
42+
self.assertEqual('5241e88d-d384-4fd7-9c2f-648b5247efc5', all_views[0].project_id)
4243

4344
self.assertEqual('fd252f73-593c-4c4e-8584-c032b8022adc', all_views[1].id)
4445
self.assertEqual('Overview', all_views[1].name)
4546
self.assertEqual('Superstore/sheets/Overview', all_views[1].content_url)
4647
self.assertEqual('6d13b0ca-043d-4d42-8c9d-3f3313ea3a00', all_views[1].workbook_id)
4748
self.assertEqual('5de011f8-5aa9-4d5b-b991-f462c8dd6bb7', all_views[1].owner_id)
49+
self.assertEqual('5b534f74-3226-11e8-b47a-cb2e00f738a3', all_views[1].project_id)
4850

4951
def test_get_with_usage(self):
5052
with open(GET_XML_USAGE, 'rb') as f:

0 commit comments

Comments
 (0)
0