Add RemoteCollection.Create()

nulltoken · nulltoken · commit c37d81816060 · 2012-02-27T10:33:26.000+01:00
diff --git a/LibGit2Sharp.Tests/RemoteFixture.cs b/LibGit2Sharp.Tests/RemoteFixture.cs
@@ -57,12 +57,13 @@ public void CanCheckEqualityOfRemote()
                 Remote otherOrigin = repo.Remotes["origin"];
                 otherOrigin.ShouldEqual(oneOrigin);
 
-                repo.Config.Set("remote.origin2.url", oneOrigin.Url);
+                Remote createdRemote = repo.Remotes.Create("origin2", oneOrigin.Url);
 
-                Remote differentRemote = repo.Remotes["origin2"];
-                differentRemote.ShouldNotBeNull();
+                Remote loadedRemote = repo.Remotes["origin2"];
+                loadedRemote.ShouldNotBeNull();
+                loadedRemote.ShouldEqual(createdRemote);
 
-                differentRemote.ShouldNotEqual(oneOrigin);
+                loadedRemote.ShouldNotEqual(oneOrigin);
             }
         }
     }
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -277,9 +277,19 @@ public static extern int git_remote_load(
         [DllImport(libgit2)]
         public static extern IntPtr git_remote_name(RemoteSafeHandle remote);
 
+        [DllImport(libgit2)]
+        public static extern int git_remote_new(
+            out RemoteSafeHandle remote,
+            RepositorySafeHandle repo,
+            [MarshalAs(UnmanagedType.CustomMarshaler, MarshalTypeRef = typeof(Utf8Marshaler))] string url,
+            [MarshalAs(UnmanagedType.CustomMarshaler, MarshalTypeRef = typeof(Utf8Marshaler))] string name);
+
         [DllImport(libgit2)]
         public static extern IntPtr git_remote_url(RemoteSafeHandle remote);
 
+        [DllImport(libgit2)]
+        public static extern int git_remote_save(RemoteSafeHandle remote);
+
         [DllImport(libgit2)]
         public static extern int git_repository_config(
             out ConfigurationSafeHandle cfg,
diff --git a/LibGit2Sharp/RemoteCollection.cs b/LibGit2Sharp/RemoteCollection.cs
@@ -71,5 +71,29 @@ IEnumerator IEnumerable.GetEnumerator()
         {
             return GetEnumerator();
         }
+
+        /// <summary>
+        ///   Creates a <see cref="Remote"/> with the specified name and for the repository at the specified location
+        /// </summary>
+        /// <param name = "name">The name of the remote to create.</param>
+        /// <param name = "url">The location of the repository.</param>
+        /// <returns>A new <see cref = "Remote" />.</returns>
+        public Remote Create(string name, string url)
+        {
+            Ensure.ArgumentNotNull(name, "name");
+            Ensure.ArgumentNotNull(url, "url");
+
+            RemoteSafeHandle handle;
+            int res = NativeMethods.git_remote_new(out handle, repository.Handle, url, name);
+            Ensure.Success(res);
+
+            using (handle)
+            {
+                res = NativeMethods.git_remote_save(handle);
+                Ensure.Success(res);
+
+                return Remote.CreateFromPtr(handle);
+            }
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,12 +57,13 @@ public void CanCheckEqualityOfRemote()`
`57`	`57`	`Remote otherOrigin = repo.Remotes["origin"];`
`58`	`58`	`otherOrigin.ShouldEqual(oneOrigin);`
`59`	`59`
`60`		`- repo.Config.Set("remote.origin2.url", oneOrigin.Url);`
	`60`	`+ Remote createdRemote = repo.Remotes.Create("origin2", oneOrigin.Url);`
`61`	`61`
`62`		`- Remote differentRemote = repo.Remotes["origin2"];`
`63`		`- differentRemote.ShouldNotBeNull();`
	`62`	`+ Remote loadedRemote = repo.Remotes["origin2"];`
	`63`	`+ loadedRemote.ShouldNotBeNull();`
	`64`	`+ loadedRemote.ShouldEqual(createdRemote);`
`64`	`65`
`65`		`- differentRemote.ShouldNotEqual(oneOrigin);`
	`66`	`+ loadedRemote.ShouldNotEqual(oneOrigin);`
`66`	`67`	`}`
`67`	`68`	`}`
`68`	`69`	`}`