lint

avishalom · avishalom · commit fb68d1450db3 · 2018-03-18T23:10:18.000-04:00
diff --git a/firebase_admin/dynamic_links.py b/firebase_admin/dynamic_links.py
@@ -114,7 +114,7 @@ def __init__(self, app):
 
     def _populated_request(self, url, options):
         days = options.duration_days
-        url_quoted = urllib_parse.quote(url, safe="")
+        url_quoted = urllib_parse.quote(url, "")
         return self._links_request.format(url_quoted, days)
 
     def get_stats(self, url, options):
diff --git a/tests/test_dynamic_links.py b/tests/test_dynamic_links.py
@@ -201,4 +201,12 @@ def test_invalid_event_stats_list(self, arg):
     def test_empty_event_stats_list(self, arg):
         with pytest.raises(ValueError) as excinfo:
             dynamic_links.LinkStats(arg)
-        assert 'elements of event stats must be "EventStats"' in excinfo.value.message
+        assert'elements of event stats must be "EventStats"' in excinfo.value.message
+        
+
+class TestQuoting(object):
+    def test_quote(self):
+        links_service = dynamic_links._get_link_service(None)
+        link = links_service._populated_request("https://sample.com",
+                                                dynamic_links.StatOptions(duration_days=1))
+        assert link == 'https%3A%2F%2Fsample.com/linkStats?durationDays=1'
