8000 Fixed pycodestyle errors. · rickyren/server-client-python@16469a9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 16469a9

Browse files
lbrendanlRussell Hay
authored andcommitted
Fixed pycodestyle errors.
1 parent af7acaa commit 16469a9

File tree

8 files changed

+10
-11
lines changed

8 files changed

+10
-11
lines changed

tableauserverclient/models/datasource_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class DatasourceItem(TaggedResourceItem):
1212
def __init__(self, project_id, name=None):
13-
super(DatasourceItem, self).__init__() #Python2 compatible super
13+
super(DatasourceItem, self).__init__() # Python2 compatible super
1414
self._connections = None
1515
self._content_url = None
1616
self._created_at = None

tableauserverclient/models/view_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
class ViewItem(TaggedResourceItem):
88
def __init__(self):
9-
super(ViewItem, self).__init__() #Python2 compatible super
9+
super(ViewItem, self).__init__() # Python2 compatible super
1010
self._content_url = None
1111
self._id = None
1212
self._image = None

tableauserverclient/models/workbook_item.py

Lines changed: 1 addition & 1 deletion
+
super(WorkbookItem, self).__init__() # Python2 compatible super
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
class WorkbookItem(TaggedResourceItem):
1313
def __init__(self, project_id, name=None, show_tabs=False):
14-
super(WorkbookItem, self).__init__() #Python2 compatible super
14
1515
self._connections = None
1616
self._content_url = None
1717
self._created_at = None

tableauserverclient/server/endpoint/datasources_endpoint.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,10 @@ def update(self, datasource_item):
9999
if not datasource_item.id:
100100
error = 'Datasource item missing ID. Datasource must be retrieved from server first.'
101101
raise MissingRequiredFieldError(error)
102-
102+
103103
self._update_tags(self.baseurl, datasource_item)
104104

105-
# Update the datasource itself
105+
# Update the datasource itself
106106
url = "{0}/{1}".format(self.baseurl, datasource_item.id)
107107
update_req = RequestFactory.Datasource.update_req(datasource_item)
108108
server_response = self.put_request(url, update_req)

tableauserverclient/server/endpoint/tagged_resources_endpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def _add_tags(self, baseurl, resource_id, tag_set):
1919
def _delete_tag(self, baseurl, resource_id, tag_name):
2020
url = "{0}/{1}/tags/{2}".format(baseurl, resource_id, tag_name)
2121
self.delete_request(url)
22-
22+
2323
# Remove and add tags to match the resource item's tag set
2424
def _update_tags(self, baseurl, resource_item):
2525
if resource_item.tags != resource_item._initial_tags:

tableauserverclient/server/endpoint/views_endpoint.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@
1212
class Views(TaggedResourcesEndpoint):
1313
# Used because populate_preview_image functionaliy requires workbook endpoint
1414
@property
15-
def siteurl(self):
15+
def siteurl(self):
1616
return "{0}/sites/{1}".format(self.parent_srv.baseurl, self.parent_srv.site_id)
1717

18-
1918
@property
2019
def baseurl(self):
2120
return "{0}/views".format(self.siteurl)
@@ -43,8 +42,7 @@ def populate_image(self, view_item, req_options=None):
4342
if not view_item.id:
4443
error = "View item missing ID."
4544
raise MissingRequiredFieldError(error)
46-
url = "{0}/{1}/image".format(self.baseurl,
47-
view_item.id)
45+
url = "{0}/{1}/image".format(self.baseurl, view_item.id)
4846
server_response = self.get_request(url, req_options)
4947
view_item._image = server_response.content
5048
logger.info("Populated image for view (ID: {0})".format(view_item.id))

test/test_datasource.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
PUBLISH_XML = os.path.join(TEST_ASSET_DIR, 'datasource_publish.xml')
1414
UPDATE_XML = os.path.join(TEST_ASSET_DIR, 'datasource_update.xml')
1515

16+
1617
class DatasourceTests(unittest.TestCase):
1718
def setUp(self):
1819
self.server = TSC.Server('http://test')

test/test_view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,4 +111,4 @@ def test_update_tags(self):
111111

112112
print("asdfasdf" + str(single_view) + str(updated_view))
113113
self.assertEqual(single_view.tags, updated_view.tags)
114-
self.assertEqual(single_view._initial_tags, updated_view._initial_tags)
114+
self.assertEqual(single_view._initial_tags, updated_view._initial_tags)

0 commit comments

Comments
 (0)
0